Skip to content

Settings: desktop accents, row dividers and segmented control - #28

Merged
Tarquinen merged 2 commits into
mainfrom
ui/settings-desktop-accents
Nov 10, 2026
Merged

Tarquinen merged 2 commits into
mainfrom
ui/settings-desktop-accents

Conversation

@Tarquinen

@Tarquinen Tarquinen commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Brings Settings and the shared controls closer to the desktop's Preferences page.

What changed

  • Blue only for on, selected and focused, using the desktop's exact tokens: switch on state (#3B5CF6 track, white thumb), text field focus border (#7698FD), the Themes radio, voice/delegator/server/menu checkmarks and the sound effects slider. Named themes use their own accent; System uses the Material You primary. Primary buttons and destructive red stay as they were.
  • Row dividers: a 0.5 dp hairline (black/white at 10%) between every row in a settings card, inset to the card padding, none after the last row. Visible in dark now (the old line disappeared on the dark card).
  • No leading icons on the detail pages (Experimental, Voice, Appearance, Sessions, Developer…), like the desktop's settings rows. The main Settings page keeps its icons, like the desktop sidebar.
  • Segmented choices (Appearance › Mode, Models) use the desktop's segmented control: 6 dp corners, the chosen segment in the base colour with a border-strong edge, muted text for the rest. Neutral, not blue, as on the desktop.

New colour tokens (selection, onSelection, focusRing, rowDivider) were added; existing tokens are unchanged. Behaviour and copy are unchanged.

Verified

  • scripts/check.sh (full: assemble, lint, unit tests) passes.
  • Emulator with session-lab in light and dark: main Settings, Experimental, Appearance, Voice and the call voice picker, the New Server form with a focused field, plus Tokyo Night in dark.

Before / after

Each row: light before, light after, dark before, dark after.

Experimental
Experimental

Appearance
Appearance

Call voice picker
Call voice picker

Focused text field
Focused text field

Main Settings page (keeps its icons)
Main Settings

Adds OpenCodeColors tokens from the desktop's theme.css (existing tokens
unchanged): selection/onSelection (--v2-background-bg-accent #3B5CF6 with
white), focusRing (--v2-border-border-focus #7698FD) and rowDivider
(--v2-border-border-base, black or white at 10%). Named themes use their own
accent; System maps to the dynamic primary.

- OpenCodeSwitch on: selection track, white thumb (was primary, which is
  neutral in the OpenCode theme). Off, size, tap target and semantics unchanged.
- OpenCodeTextField focus border: focusRing instead of primary.

Verified: $V check (full) passes; emulator with session-lab, light, dark and
Tokyo Night.
Brings Settings closer to the desktop's Preferences page:
- SettingsDivider: a 0.5 dp rowDivider hairline inset to the card padding on
  both sides (was a 1 dp border-colour line that vanished on the dark card);
  under an iconed row it starts at the text.
- Detail pages (Experimental, Voice, Appearance, Sessions, Developer...) drop
  their leading row icons, as the desktop's settings rows have none. The main
  Settings page keeps them (LocalSettingsRowIcons), like the desktop sidebar.
- SettingsSegmentedControl replaces Material's pill segmented buttons in
  Appearance › Mode and Models: the desktop segmented control, 6 dp corners,
  chosen segment in the base colour with a border-strong edge and base text,
  muted text for the others. Selection stays neutral, as on the desktop.
- Selection marks in the accent: Themes radio, call-voice checkmark, session
  delegator checkmark, current server checkmark, menu row checkmarks, sound
  effects slider.

Verified: $V check (full) passes; emulator with session-lab in light and dark
(main, Experimental, Appearance, voice picker, New Server field) and Tokyo
Night dark.
@Tarquinen
Tarquinen merged commit 13b688e into main Nov 10, 2026
1 check passed
Tarquinen added a commit that referenced this pull request Nov 12, 2026
refactor(settings): trim PR #28's settings chrome

This branch was previously deployed

1 inactive deployment
release — 80ba8918 Deployed Nov 10, 2026 by Tarquinen via check #91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant