Repository navigation
Settings: desktop accents, row dividers and segmented control - #28
Merged
Merged
Conversation
Adds OpenCodeColors tokens from the desktop's theme.css (existing tokens unchanged): selection/onSelection (--v2-background-bg-accent #3B5CF6 with white), focusRing (--v2-border-border-focus #7698FD) and rowDivider (--v2-border-border-base, black or white at 10%). Named themes use their own accent; System maps to the dynamic primary. - OpenCodeSwitch on: selection track, white thumb (was primary, which is neutral in the OpenCode theme). Off, size, tap target and semantics unchanged. - OpenCodeTextField focus border: focusRing instead of primary. Verified: $V check (full) passes; emulator with session-lab, light, dark and Tokyo Night.
Brings Settings closer to the desktop's Preferences page: - SettingsDivider: a 0.5 dp rowDivider hairline inset to the card padding on both sides (was a 1 dp border-colour line that vanished on the dark card); under an iconed row it starts at the text. - Detail pages (Experimental, Voice, Appearance, Sessions, Developer...) drop their leading row icons, as the desktop's settings rows have none. The main Settings page keeps them (LocalSettingsRowIcons), like the desktop sidebar. - SettingsSegmentedControl replaces Material's pill segmented buttons in Appearance › Mode and Models: the desktop segmented control, 6 dp corners, chosen segment in the base colour with a border-strong edge and base text, muted text for the others. Selection stays neutral, as on the desktop. - Selection marks in the accent: Themes radio, call-voice checkmark, session delegator checkmark, current server checkmark, menu row checkmarks, sound effects slider. Verified: $V check (full) passes; emulator with session-lab in light and dark (main, Experimental, Appearance, voice picker, New Server field) and Tokyo Night dark.
Tarquinen
added a commit
that referenced
this pull request
Nov 12, 2026
refactor(settings): trim PR #28's settings chrome
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings Settings and the shared controls closer to the desktop's Preferences page.
What changed
#3B5CF6track, white thumb), text field focus border (#7698FD), the Themes radio, voice/delegator/server/menu checkmarks and the sound effects slider. Named themes use their own accent; System uses the Material You primary. Primary buttons and destructive red stay as they were.New colour tokens (
selection,onSelection,focusRing,rowDivider) were added; existing tokens are unchanged. Behaviour and copy are unchanged.Verified
scripts/check.sh(full: assemble, lint, unit tests) passes.Before / after
Each row: light before, light after, dark before, dark after.
Experimental

Appearance

Call voice picker

Focused text field

Main Settings page (keeps its icons)
