Repository navigation
Sync to iOS 01eef583 (merged with main's desktop design) - #5
Merged
Merged
Conversation
ios-sync.py plan and stale --to 3d50fd74: 19 rows marked sync, 2 todo rows added. Verified: ios-sync.py check.
Composer (62f56e19): - ComposerDismissTarget.current picks what the 4,000 dp dismiss area is mounted for: the open Attachment menu, else autocomplete only while its rows are drawn. SessionComposerHost.showsAutocomplete (published by ComposerCapsule) and floatingCallCovers decide "drawn", so a request panel or call holding the glass no longer leaves an invisible catcher. - ComposerMorph.open()/close() clear a pending fold, so the morph never stays open without isOpening (Back and close guards bailed). - n/a: the keyboard band's takesTouches and the photo sheet's keys latch (Android has no keyboard band; the IME is a system window). The morph backdrop already takes taps only while open. Drawer (da4aeda3): - DrawerMotionState.updateWidth lands a card at rest where the model says (logs drawer_pose_resettled), so a drawer opened before it had a width lands open with its card's touches taken. Skipped while catching up (Catch Up owns the pose). This replaces the old width-0 special case, which moved the offset but left content/arrival state shut. - SessionPageStack logs page_stack_back_drag_ignored when a back drag begins mid-pop. dragBegan already refused it, so the pop lands. - n/a: Catch Up giving every page its touches back (Android never takes the card's pages' touches), the drawer net's ajar / shut-while-open fault (Android has no drawer touch net), and iOS's file moves. Tests: ComposerMorphPhaseTests (1), AttachmentMenuPressTests .theDismissAreaIsMountedOnlyForWhatIsDrawn, DrawerTouchStateTests (drawer 2, session 1). Parity rows, test totals and the sync plan are updated. Verified: scripts/check.sh :core :feature:composer :feature:session :feature:drawer passed (composer 278, drawer 536, session 775 tests, 0 failures); ios-sync.py check: 0 errors.
…iOS 3d50fd74) Ports iOS 32c6dac8, cd9a5c4d, 450d6e57, 3d50fd74 and adfb5188. - TranscriptListController: a reshown list (screen or app returning) drops an isUserGestureActive hold whose drag never reported its end (releaseStrandedGesture, content-free `transcript_gesture_released` log), so following, keyboard riding and New landing work again without a new drag. iOS's scroll-to-top flag, selection-autoscroll release and shrunk-end guard are n/a: Android has no isScrollingToTop flag, the selection autoscroll is the list's own scroll mutation, and the settle already needs no gesture. - TouchRecovery: backoff, forgiveness and deadlines run in real seconds (sample(now, wall)); Fault.Grace (animation grace capped at 4 real s, or a hard Wall deadline) and Fault.startedAt; Reason.Stranded; expedite (dead drag, no Android caller); `trigger=` in the recovery log. - The transcript's mark hand-off gets a .transcript touch-recovery watch: a Transition fault with a 2.5 real-second deadline timed from the hand-off's start (Clock), released by finishHandoff. - What's New: "Scrolling Unsticks Itself" (scrolling-unsticks). - RunErrorTests (adfb5188) needs nothing: the Android harness cancels the first store's effect scope, so no late poll tick arrives. - Dead-drag net, disabled hosts, stranded recognizers and TouchProbe stay n/a (UIKit hit chains/recognizers). Tests: TouchRecoveryTests +2, MarkLoadingTests +4 (incl. 3 hand-off tests from TranscriptTouchSafetyTests), new TranscriptGestureReleaseTests (2 of 6). Parity rows and the sync plan updated. Verified: scripts/check.sh :core :feature:transcript :feature:session :feature:settings :devtools (BUILD SUCCESSFUL; core 140, transcript 303, session 774, settings 101, devtools 17 tests, 0 failures); scripts/ios-sync.py check: 0 errors. No emulator run.
All plan items in sync/ae029f85-3d50fd74.md are ticked and no sync: rows remain. Verified: ios-sync.py check (0 errors) and the full scripts/check.sh.
ios-sync.py plan and stale --to 3f473f75: 16 rows marked sync, 1 todo row added. Verified: ios-sync.py check.
Ports iOS fbe8a131 and 4c9781f7. Launch restores Home as reconnecting until its first snapshot, so the pill flashed on every launch and nudged the transcript. ServerConnectionGrace (a composable on HomeViewState) holds "Reconnecting…" back for ServerFlowTunables.grace (2 s) while the app is resumed, starts over after the background, and shows at once for a retry from a pill already on screen. ServerConnectionNotice takes reconnectingIsDue; HomeSessionStack reads the list context again when the grace runs out. Adds What's New "Steadier Launch". Verified: scripts/check.sh :feature:session :feature:drawer :feature:settings passed; ios-sync.py check 0 errors.
…und (iOS f261300b, 3f473f75) Port iOS f261300b and 3f473f75 so the app stops sending timed reads into a dead route or from the background: - Session: pending-work polls and the reconciliation watchdog run only while Home hears from the server and the app is in front (`pollsServer`). Losing the connection or going into the background cancels them, along with any request reread in flight (`quietServerPolling`). A reconnect or the return restarts them (`resumeServerPolling`). A reconnect in the background reads pending work once. - Home: a swapped-in screen takes Home's connection and the outgoing screen's background/scene state, so it resumes on the return; a pushed subagent takes its parent's. The snapshot reconnect also tells an open draft, so the session it becomes polls. - Shell glyph probes pause while offline and send once. The shell sheet backs off a failing server (3, 6, 12, 24, 30 s). Catch Up's inert preview never probes. - Settings: the connection card keeps one check out at a time (tailscale/tailscale#21773). Settings › Voice asks only the connected server; Voice Provider's page asks the others (`ProviderPageAppeared`). - Tests: ported the modified iOS tests and the new SessionFeatureTests+QuietPolling (5 in :feature:session, 3 Home tests in :feature:drawer). The drawer `sessionStore` helper now builds the reducer under the test's dependencies, as :feature:session's does, so `SessionTimers` reaches the watchdog. - Parity docs: rows restored with sync notes; plan items ticked, except the Reconnecting pill commits. Verified: scripts/check.sh :server :feature:session :feature:drawer :feature:settings :feature:voice :app (BUILD SUCCESSFUL; session 780, drawer 539 tests). ios-sync.py check: 0 errors.
Every item in docs/parity/sync/3d50fd74-3f473f75.md is ported or marked n/a; ios-sync.py check reports 0 errors.
ios-sync.py plan and stale --to 3cea48b2: 35 rows marked sync, 3 todo rows.
…er asked (iOS f475a7a7) Turning Always Notify on used to fail with "Turn on notifications in Settings first." when the app had never asked for POST_NOTIFICATIONS. It now asks first, as iOS does, and only fails once permission was actually declined. Ported alwaysNotifyAsksForNotificationsWhenNeverAsked. Verified: scripts/check.sh :feature:voice :feature:session :feature:drawer.
…read lock when the gap meter is off (iOS 8e1fda98) - VoiceFeature.State.activeEngine/activeProvider are read from activeRoute instead of stored copies that could drift; tests set the route. - RenderedGapMeter.add returns before locking unless the lab enabled it, so normal calls take no lock per rendered buffer (iOS makes the meter DEBUG-only; Android's lab switch is an env flag, not a build flag). - Removed dead LiveOutboundQueue.isContextOnly, showsPoorConnection and scopeStage. - 8a5deded (Swift nonisolated deinit) and 2e1e15ab (iOS docs) are n/a. Verified: scripts/check.sh :feature:voice :feature:session :feature:drawer; ios-sync.py check 0 errors.
…iOS 3cea48b2) Ports iOS 9c94975e, bf0dbcb7, 5d8b2f8c, 477a3ca5, c9d19e20 and c50689e1 so a server is reached on whichever of its addresses answers (e.g. Tailscale away from home) and brief drops no longer flash Reconnecting/Offline. - :server: new ServerLink.kt (ServerLinkClient/ServerLinkStore: one shared /api/info race per server, 3.5 s, no redirects, identity checked via ServerInfoPayload.identifies; resolve/route/adopt/invalidate; pool resets on reroute, Try Again, a return after >= 20 s away, two timeouts after an answer, coalesced within 1 s). NetworkPath.kt: status + interfaces snapshot, routeSignature, 250 ms reroute debounce, path_change logging, NetworkPathClient.nextReconnectCue, AppPhases.observe. OpenCodeTransport: RotatingPools (fresh OkHttp clients; retired connections evicted after 2 s). LiveTransport routes per attempt, forgets failing addresses, interrupts idempotent GETs when the route or pools change. LiveEvents: 4.5 s/45 s EventStreamWatchdog and PoolResetWatch. RetryPolicy.stream fast for 15 s, then up to 300 s; RetryPause.Kind.waitsForNetwork. Files/media/voice/ Settings probe resolve through the link. - Drawer: HomeConnectionFeature owns the Reconnecting grace (2 s quiet, Offline after 12 s with two failures or 4 s with no path, 401 at once, Try Again shows it at once); SceneBecameActive resyncs only after the background, without a live stream or after 20 s of silence. Replaces the view-timer grace (ServerConnectionGrace, reconnectingPillIsDue, reconnectingIsDue); pill and title read connection.displayedStatus. Snapshots no longer rewrite the saved server. - App: connect probes via ServerLinkClient; saving keeps the address order (keepingAddressOrder, also in remember()). Rank race removed. - ClientTools: backoff to 60 s, reroute redials, one server-answer wake per stretch, dials via ServerLinkClient.route. VoiceCallLog reads the shared path monitor. Diagnostics: recordLink + Troubleshooting rows. What's New "Steadier Server Connections" (phone/Quick Settings wording). Android differences: per-host requests were already uncapped (iOS raises to 12); retired dispatchers aren't shut down because ClientTools and the call's RTC client hold a client for their lifetime; tunables stay constants (no Tuning Panel); EventStreamPressureTests receives one extra grace action because Android's TestStore reduces effect actions at receive. Tests: ported ServerLinkTests (25), ServerLinkPoolTests (14 :server, 2 drawer ServerLinkResetTriggerTests, 1 voice), ServerLinkConnectionTests (14 drawer, 4 :app AppFeatureTests), ClientToolsTests (+2), updated the changed iOS tests; WireFixture gains Reply.Open and Reply.Silent. Parity docs updated, sync plan items for these commits ticked. Verified: scripts/check.sh :core :server :feature:system :feature:voice :feature:session :feature:drawer :feature:settings :devtools :app passes (server 311, drawer 553, system 108, voice 732, app 158, all passing); ios-sync.py check: 0 errors. No emulator used.
All plan items in docs/parity/sync/3f473f75-3cea48b2.md are ported or n/a (server-address racing and rotating pools, the reducer-owned Reconnecting grace, Always Notify permission, voice cleanup). Verified: ios-sync.py check reports 0 errors.
… dispatcher CI failed NewMessagesReceiptTests.aReceiptInFlightAcrossAConnectStillSwallowsItsEcho. The 4.5 s connect watchdog (iOS 9c94975e) slept with delay() on the live clock in the collector's scope; under runTest that is virtual time, so while the read waited on OkHttp's thread the scheduler skipped straight to the deadline and cancelled a stream that was about to answer. With the live clock the watchdog now runs on Dispatchers.Default, where its deadlines are real seconds (no change in the app, which collects on a real dispatcher). A scripted NetworkRetry.clock stays on the stream's own scope, as its tests move it. Verified: under full CPU load the receipt test failed 6/6 before and passes 10/10 after; scripts/check.sh :server :feature:drawer :app passes.
ios-sync.py plan/stale --to 440b77f0: 34 commits, 122 rows marked sync, 20 todo, 3 removed.
…ries Ports iOS 0eb5c365, 18a24be6, 432b74e8, d96aecec, 92a19c0d, 6b072111, d9f75bbd and 02d0abe5. App (0eb5c365): AppFeature.State.presentsOverApp is the one answer for what covers the app (client tools' screen block uses it; it feeds isPresentingAnything). Pairing lives in AppFeaturePairing.kt: validatePairing, the new pairingProblem, requestPairing, beginPairing, redeem and the pairing messages. The scanner entry point is renamed beginScanningPairingCode. serverNoLongerSavedMessage and sessionNoLongerAvailableMessage replace duplicated literals. Test renamed to credentialFieldFocusOrderAndNamePromptUsesFriendlyName. PendingPairing stays nested in AppFeature (Kotlin can't nest across files). Share (18a24be6): SharedImageEncoder moves out of ShareHandoff.kt into its own file; SharedItemLoader and ComposerFileStaging were already split. Media (92a19c0d): AgentImagePreviewsReads.kt renamed AgentImageReads.kt, AgentImageSizeCache moved to its own file, and store entry writes go through one mutate/settle pair. AgentTextDocument was already separate. Link previews (6b072111, 02d0abe5): one DeferredRetries machine for links and icons deferred off a constrained path; clear() also drops path retries so every answer resets them; one freshness rule, LinkPreviewLoader.freshLifetime. No Android change for d9f75bbd (Android already shares one fade and one all-corners mask; the browser edits net to nothing after 02d0abe5), 432b74e8 (iOS docs) or d96aecec (ratchet script). Verified: scripts/check.sh :app :core :feature:system :feature:media (build, lint, unit tests) passes; ios-sync.py check reports 0 errors.
…aae53e ee7efcfc 7f95ab69 cda508ba a32edc20 b5314d5f) Server: - NetworkPathClient drops the unread isConstrained/isExpensive fields; the project-icon loader reads NetworkPathMonitor directly, as on iOS. - ServerLinkClient drops the test-only lastRace accessor and the store's race map; settle no longer takes the race summary. - RetryPolicy.jitter shares the equal-jitter maths between delay(n) and the fast retry window. - ConnectionFailureDetail.isTailnetAddress classifies through HostAddress. Transcript: - Timestamp ID comparisons use one wrap rule (HALF_RANGE). - Drop the never-read Hit.isCode from reply selection (Android's hold already selects code; code blocks aren't drag sources, so iOS's hold-selected-code-to-drag is n/a). - New-messages KDoc loses stale experiment wording. - 7f95ab69 n/a: Android's list update already ignores snapshotRevision-only changes and has no tail-markdown reconfigure fast path. Settings: What's New drag-from-transcript example copy matches iOS. Drawer: - Remove the graduated Project Icons plumbing: showsProjectIcons, twoLineRows, DrawerRowLayout/rowLayout, the two-line subtitle; every row resolves its project. - Remove the unused search onBegin/beginSearch path. - isMuted/isUnread delegate to statusSnapshot and the attention scan takes one status snapshot (b5314d5f). The busy-top sync half is n/a: Android derives busyTopIDs, there's no stored observed set to resync. Parity docs updated; plan items ticked except HomeSettingsFeature (f956e020). Verified: scripts/check.sh :server :feature:transcript :feature:settings :feature:session :feature:drawer passes (a first run hit a load-timing flake in MultipleWindowsTests, which passes alone and on rerun); ios-sync.py check: 0 errors.
…6147c, 16a88012, 1385761f, 3e496d99) Session file splits (706638fe, e946147c): - SessionFeatureSend.kt split like iOS: the outbox helpers (holdStoppedSends, stopDraft, restoreOutbox, enqueueRunningPrompt, retry, markFailed, removeFailedSend, restoreFailedSends, publishCache, ...) move to SessionFeatureOutbox.kt, the undo helpers (returnToComposer, stageRevert, hydrated, reportRevertError, fillComposerDraft) to SessionFeatureUndo.kt. The orphaned "Retry, Edit, and Delete..." doc line now sits on removeFailedSend, as on iOS. A few helpers went private -> internal to cross files. - The SwitchSnapshot region (from/restore/pruneRequests/restoreSessionData) moves from SessionFeatureState.kt to SessionFeatureSnapshots.kt. The nested SwitchSnapshot and State.Refresh types stay in SessionFeature.kt (Kotlin can't declare nested types in another file). - Dead helpers dropped with iOS: State.isVoiceAvailable(enabled, apiKey) and State.canStartCallFromTap (plus the unread canStartCallFromTap field of the composer snapshot). Composer swipe (16a88012): Android already has one shared composerSwipes handler, so nothing to merge; the VoiceLiveTests comment no longer cites the removed static helper. Composer dead code (1385761f): - AttachmentMenu.kt: the card/picker overlay, AttachmentMenuLinger, InlinePhotoFilter, morph, the plusMenuSheet flags and card metrics are gone; the overlay becomes AttachmentMenuMeasure (measures the rows, seed and menu, draws nothing). AttachmentMenuPhotoPicker.kt (inline card picker, only used by the overlay) deleted. dragDismisses moves to PlusMenuPlacement. - One photo cap (MAX_PHOTO_SELECTION = 8) and one hold (PlusMenuTunables.HOLD_DURATION); pastes/shares import 4 at a time. - usesPlusMenuSheet branches made unconditional in SessionViewPhotoSheet.kt; ComposerTunables.attachmentRadius(plusMenu) removed. - PhotoRequestGate -> OneShotRequestGate (own file, iOS name); PlusPhotoPill -> PlusPhotoPillControl; PlusPhotoLibrary latches shownPickCount through the close. - Request failures: failedReplyIDs/failedDismissalIDs/settledRequestIDs become one requestFailures map of RequestFailure (Reply/Dismissal/Settled/SettledDismissal); the state forwarder failedReplyIDs is gone. Settled dismissal copy (3e496d99): a settled dismissal reads "Couldn't dismiss request" (RequestFailure.SettledDismissal). iOS has no test for it. Tests ported as iOS changed them: linger tests deleted (incl. the drawer's AttachmentMenuPressTests.kt), theMenuUsesItsTunedHoldAndSprings, image import limit 4/8, shownPickCount, requestFailures in RequestAnswer/ RequestReview/Subagents tests. Parity docs and the sync plan updated. Verified: scripts/check.sh :feature:composer :feature:session :feature:voice :feature:drawer -> BUILD SUCCESSFUL (composer 277, session 781, voice 732, drawer 552 tests, 0 failures; run with java.io.tmpdir under build/ because the shared /tmp hit its disk quota). ios-sync.py check: 0 errors.
… Playground
Ports iOS 85945779.
- core/motion: Motion gains the fourteen MotionRole constants (press, microIn,
microOut, swap, layout, collapse, panelOpen, panelClose, surface, release,
flight, keyboard, dim, reduced) with iOS's approved starting values, tunable
under motion.springs/fades/geometry/ambient (four sections). Motion.register
drops overrides on retired keys (isRetiredKey).
- New MotionRole.kt (MotionPhase, MotionCurve, role curve/animation/staggered,
one Reduce Motion translation to the 0.20 s ease-in-out cross-fade, role-based
SpringSolver factory and retarget), MotionPress.kt, MotionReduce.kt
(MotionReduce, MotionPose, Modifier.motionPose), MotionRelease.kt (release
rule with reverse-flick veto, invertible MotionRubberBand,
MotionFlightGeometry), AmbientClock.kt (one clock for breath/sweep plus an
AmbientTimeline that pauses under Reduce Motion, when inactive, or when the
lifecycle isn't resumed). PresenceGate.kt adds MotionPresence,
MotionTransition (micro/swap/roll) and MotionSwap.
- Today's call sites keep their numbers via deprecated aliases (legacyPanelOpen,
morphClose, settle, disclosureOpen, disclosureClose, microPop, fade aliases);
SharedLocation moves to Motion.legacyPanelOpen as iOS did. Dead morphOpen,
handoffDelay and foldHandoverRatio are deleted.
- Tuning: TuningContext.panelGroups/globalGroups ("motion" on every screen) and
motionPlayground context; TuningPanelGroups.shown uses panelGroups.
- devtools: Settings > Playgrounds > Motion (MotionPlaygroundView), one example
per role with a Reduce Motion switch.
- Tests: MotionSystemTests ports the iOS role, alias, reduce-motion, solver,
release, rubber band, flight and ambient tests; new TuningMotionGroupTests.
- Parity docs and the 3cea48b2-440b77f0 sync plan updated.
Verified: scripts/check.sh (assembleDebug + lintDebug + testDebugUnitTest, all
modules) passes; ios-sync.py check adds no errors.
…e's call bar, rename clear buttons (iOS b521774d..440b77f0) Ports iOS b521774d, 6b6fa423, b83433f0, 10a0aafd, f956e020, 7d217695, e0b42ec5, 440b77f0 and 93fb1adc. - Server Voice graduates (f956e020, OC-440): the `serverVoice` experiment is gone along with every off branch. Calls now always resolve through Voice Provider (Automatic: the connected server, then the phone's key, then another ready saved server). "server-voice" is added to the retired experiment keys, so a saved switch is cleared at launch. `VoiceBroker`, `VoicePick.resolve` and `VoiceRoutePreferences` no longer take the flag. Settings › Voice shows the Voice Provider row for every engine except Grok. The server-unsupported footer and `showsServerUnsupported` are removed. `checkVoiceServers` no longer has a guard. Tests that cover calls on the phone's key now pin This Phone, as on iOS. `flagOffRequiresPhoneAPIKeyExactlyLikeMain` and `settingsAsksNoServerWithServerVoiceOff` are removed with the experiment. - What's New (7d217695, 93fb1adc): new entries server-voice and rename-clear-button. The two older voice entries are folded into server-voice, and the copy of three voice entries is reviewed. "iPhone" becomes "phone". - Rename prompts get a clear button (e0b42ec5, 440b77f0). The new `core/ui/AlertTextFields.clearButton` adds a trailing × button while a field is non-empty. It is used in Rename Session, both Rename Server dialogs and Paste the Code. iOS instead uses a UIKit appearance rule. - Long calls' captions stay bounded again (6b6fa423): `FloatingCallTranscript` trims `CaptionReveal` on first draw and after each settle. - The dot scope's call bar is retired (b83433f0): `DotScopeMode.Call` and `Panel`, the scan, tray and stage state are gone, and `Scan` is now just sweep geometry for the call sounds. The scope tests and haptic tests follow iOS. - The orb's unused states are removed (10a0aafd): error and pulsing, the pulse rings, the `isConnecting` config and the bloom corner. The uniform layout shrinks to 63 `float4`s. The floating call reads `center.place` and the reducer's `dragTarget` in place of local copies. - Wrappers are removed (b521774d): `VoiceProviderGroup`, the unused `SettingsMenuRow` caption, symbol and tint, `WelcomeScene.phonePoint`, and the dead `TuningStore.unregister(keys)`. The parity rows and the plan in docs/parity/sync/3cea48b2-440b77f0.md are updated. These items stay unticked because they also list another group's commit: TuningTests (85945779), VoiceLiveTests (16a88012) and SessionFeature+State (e946147c). Verified: scripts/check.sh :core :feature:voice :feature:settings :feature:session :feature:drawer :app passed (BUILD SUCCESSFUL), and scripts/ios-sync.py check reports 0 errors.
Every group of the 3cea48b2..440b77f0 port is merged, so the rows two groups shared (AppView, SharedLocation, MotionConstants, SessionFeature+State, SessionView+Attachments, SharedKeys, PresenceGate) are done and every plan item is ticked. Verified: ios-sync.py check 0 errors; full scripts/check.sh passes and every module's test count matches its parity total.
Since the list-owned reply selection landed, code blocks and display math
could only be selected, never dragged, though What's New tells people to
"select a line of code in a reply, then hold the selection and drag the
block into Notes". Port iOS cda508ba's drag half:
- Code bands and display math in a reply are transcriptDragSource again
(TranscriptDragPayload.Code(source, language); math as its TeX with
language "tex"), band surface, radius 10, on the band's full width via a
new MarkdownBand(bandModifier).
- TranscriptReplySelection.Hit gains liftsWhenSelected (code or math leaf)
and holdSelects(point) / holdSelects(hit) (iOS holdSelects(at:)): a hold
on a link, or on code/math inside the current selection, doesn't select.
The hold gesture uses it, so a hold on selected code leaves the touch to
the drag source.
- The drag source node asks the reply selection first (iOS
selectionOwnsHold): nothing lifts while a selection drags, and code/math
lift only when the hold wouldn't select. The selection is kept, as on
iOS. Outside replies code and math keep their SelectionContainer and
don't drag.
Parity rows for TranscriptDragSource, TranscriptCollectionView,
TextSelection, TranscriptReplySelectionView, MarkdownBlockView and
MathRendering corrected (the drag part was marked n/a).
Verified: scripts/check.sh :feature:transcript :feature:settings passes
(java.io.tmpdir moved off a full /tmp for Robolectric); ios-sync.py check
0 errors. Emulator (API 36, session-lab): a hold on unselected code
selected the word with Copy/Quote/Select all and started no drag; holding
the selected word and moving started a platform drag (WindowManager
"perform drag ... ClipData { text/x-swift text/plain {T(178)} }", the whole
block); same for display math (first hold selects, then text/x-tex drag).
All 34 iOS commits from 3cea48b2 to 440b77f0 are ported or noted n/a (85f1b240 UI tests, be04282d and cf0d0e06 release docs). Verified: ios-sync.py check 0 errors; full scripts/check.sh passed before the code-drag commit, and scripts/check.sh :feature:transcript :feature:settings after it.
Generated with scripts/ios-sync.py plan and stale --to 03adf07a: 175 rows marked sync, 9 todo, 1 removed. sync.json target set to 03adf07a.
…delegated replies; connecting caption on a surface Ports iOS a049050c, a8c7ca1b, d9027b53, 8bbbd1ef, 24c0e830, eb60ee6d, 4c164848, e555eb3a, 9a877cf4, 636c978c, 0ef56d20 and 20f2a2c6. - Diagnostics (a049050c): DiagnosticsJournal buffers appends and writes them in batches on its executor (after 250 ms, at 64 KB, or before a segment would overflow); reads, flush and markBackground write what is pending first; markBackground(waits) for tests. DiagnosticsRecorder sweeps unfinished request starts every 64 events or 5 s instead of on every event. - Touch recovery (8bbbd1ef, 9a877cf4): one TouchRecoverySampler timer runs only in armed windows (grace + 1 s), stays awake while a fault or its backoff stands, then stops: 0 Hz at rest (was a 4 Hz poll per watch). A touch-down arms it (MainActivity.dispatchTouchEvent, the iOS arming recognizer that fails at once); owner recompositions too. - Dot scope (24c0e830, e555eb3a): a scope quiet for 1.5 s draws every other frame; prepare() warms once a launch. The GPU beam field is n/a (AGSL has no compute; the grid is already lit off the main thread). - LiveRTC playout clock (eb60ee6d): n/a, Android's playout is pushed by AudioTrackSink, with no polling thread. - Voice call log (4c164848): the live copy is written at most every 10 s; delete still waits on the serial executor. - Voice (636c978c): delegated sessions answer at length when asked (new activeCallBlock copy), the 8,000-character handoff reply limit, and long replies are read in full (no commentary chunk cap). - Screen visibility (0ef56d20): n/a, Android has no layer KVO observer. - Connecting via… caption (20f2a2c6) sits in a capsule on the call surface (iOS glass), plus its What's New entry. Tests: ported DiagnosticsJournalWriteTests, the recorder sweep test, 3 touch recovery sampler tests, the dot scope quiet test (rate half), the call log throttle test, and the 636c978c voice tests; TraceTests waits for the background write. Parity rows, test totals and the sync plan updated. Verified: scripts/check.sh :core :feature:voice :feature:system :feature:settings :feature:session :devtools :app passed (core 153, voice 731, settings 100 tests); ios-sync.py check: 0 errors.
…on roles) Ports iOS 9a39cafd, 670204e5, 3fd753e7, 11b4df9f, 09b3ac03, eb57b4fc, 060558cb, a87677a5 (94736f94 is UITests/session-lab only). - Link previews (9a39cafd): LinkPreviewLoader.stale reads memory only, so drawing never touches the disk; after a load that left nothing, LinkPreviewStore draws the stale preview that load read from disk. - Agent image sizes (670204e5, 3fd753e7): AgentImageSizeCache reads its file once via warm() on Dispatchers.IO (at init and from OpenCodeApplication.onCreate), decodes outside the lock and merges with entries stored meanwhile (newer wins); size/store touch memory only and nothing saves before the read lands. Downloads inspect only the first 256 KB for a size (HEADER_INSPECTION_BYTES). - Motion roles (eb57b4fc, 060558cb, a87677a5): Settings (theme preview, Experimental highlight, page titles, Reduce Motion page fade, back-swipe release, server brand spinner on the ambient clock, server details lists/errors, What's New sweep on AmbientTimeline), connection card (Try Again on micro, status on swap, milliseconds roll on layout), voice key editor on layout, app shell copy checkmark on swap, media viewer (MediaMotion is roles), image gallery pixel fade/appear/stagger (Bento's fade/stagger/appear tunables removed), browser Ask and reply capsule on panel open, back-swipe arrival on release, image viewer controls on swap, zoom cross-dissolve on reduced, and the Share sheet (shared press, swap glyphs, layout phases, spinner per half sweep, still under Reduce Motion). - n/a: BadgeAuthorization caching (11b4df9f; no separate badge permission on Android), MadeOnce (09b3ac03; Compose remember already builds once), ShareMotion and ShareComposition.Roles (the sheet reads MotionRole directly), LaunchBloom fade curve (hard cut), Tuning Panel and TraceTriggers motion. - Tests: aColdMissReadsTheDiskInsideTheLoadNotWhileDrawing, aRememberedShapeIsReadOnceOffTheMainActor, aReadLooksAtTheFirst256KBOnly. - Parity docs and the 440b77f0-03adf07a plan updated. Verified: scripts/check.sh :core :feature:media :feature:system :feature:settings :devtools :app (BUILD SUCCESSFUL; media 190, settings 100, system 108, app 158 tests, 0 failures); ios-sync.py check: 0 errors.
Ports iOS cf30d03b, 2b967b3f, 998374a7, 7d09d4a8, b3297d63, 35d31d2f, 25274c89, 8b3aefdb, 06718dd8, 7c5febff and d921863e. Mermaid (cf30d03b): MermaidSyntax.hash is memoized per source, so a recomposing card stops re-hashing. The offscreen WebView is torn down after 30 s idle, and memory pressure purges rasters (resetting the WebView when nothing is pending). MermaidLayout and warm-from-parse are n/a: Pele already runs inside the WebView renderer, off the main thread. Render work (7d09d4a8, 35d31d2f, b3297d63): MathRenderer caches whether a formula typesets, independent of size, so selection text typesets each formula once. Finished Markdown blocks already skip on tail deltas (@immutable block, keyed rows, strong skipping), so no change there. Paging (8b3aefdb, 2b967b3f): a browsing reader scrolling up asks for earlier history 2.5 screens ahead (one screen at the end, as before). Selection arming (998374a7) is n/a: the Android anchor is one Modifier.Node per leaf with no view or global-position callback. Cell measurement and batch updates (2b967b3f, 25274c89, 8b3aefdb) and idle near-screen repaint are UICollectionView-only. Motion roles (d921863e): row entrance, disclosure, band fade, divider, promotion, link-preview changes, mark hand-off, empty state, overflow fade, copy glyph, growth soft edge, inline pulse and the send pill now use Motion roles/tunables. The matching TranscriptTunables knobs, EmptyStateTunables/MarkLoadingTunables fields, the LinkPreviewMotion object and AgentImageTunables.grow are removed. One line changed outside transcript: SessionSendFlight (pill on Motion.flight). Tests: TranscriptRenderWorkTests (2), mermaidSourcesHashOncePerSource, MarkLoadingTests and TranscriptScrollBehaviorTests updated as on iOS. Verified: scripts/check.sh :core :feature:transcript :feature:media :feature:settings :feature:session :devtools :app passes (transcript 305 tests, 1 skipped; media 188); ios-sync.py check reports 0 errors.
iOS b0e1fd4b, 816fd931, c8b93a9d, ed9d54e1, a099f459, 4c2fb0be, 8089acbd, 9764fc7d, 6a9a30c7. Session window: 2 s after a browsing reader returns to the end, or sends from history, the rendered window settles back (RenderedWindowSettled, CancelID.WindowReset, SessionTimers.windowReset). It keeps the last 45 entries counted from the Revert boundary, at least 20 rows, the New divider, and the bottom turn back to its prompt within 120 rows. Show Earlier, browsing again, a new screen and a family switch cancel the wait. Bounded work: acceptWindow stops at the first durable row older than the window. mergeTranscript links only the overlapping span. refreshResponse indexes raced parts once. MessageRows matches a message's rows without building strings per row. NewMessagesMark.firstUnseen reads only the tail after the last seen row. SwitchSnapshot and noteLeaving keep the newest 120 seen rows. An older page publishes AcceptedTranscriptUpdated only when it changes the cached tail or the New mark. TranscriptScan (moved down to :feature:transcript, where NewMessagesMark records into it) counts the rows walked, for tests. Server: ParsedMessageCache reuses the parsed rows of unchanged messages (256 messages keyed by message ID and payload hash; drops the least recently read half; never keeps inline image bytes or pasted files over 64 KB). History pages hold 80 messages, time out after 20 s and record history_page_* LabMarks. ServerLink keeps the active address through one failed request when its event stream sent a line after the request went (iOS 8089acbd's fixed 20 s window, as replaced by 6a9a30c7). An answer or adopting an address starts the count over; an ended stream doesn't count. Not applicable: Hashable payloads (Kotlin data classes already hash structurally); the Bindings ignore list; the env-gated CPU benchmark line; the UIKit-harness SessionWindowTests case. Tests: new SessionWindowTests (8 of 9), SessionReconciliationScanTests (9), ParsedMessageCacheTests (4) and 4 ServerLinkTests. The Loading and Resume tests no longer expect a publish from an unchanged older page. Parity docs and the sync plan are updated. Verified: scripts/check.sh :core :server :feature:session :feature:transcript :feature:drawer :app passes (:server 319 tests, :feature:session 798). One earlier full run failed only ServerLinkTests.aStreamStrandedOnADeadRouteEndsAsATimeout (timing under load); ServerLinkTests then passed 3 times on its own and the full rerun passed. ios-sync.py check: 0 errors.
…sion chrome Ports iOS d0b24aaa, 3fa29077, 4d167bd3, f32303bf, 8aad7be1, bb4e47f7, 20a4df58, 8bd26820, a5b86a4f, 4eb55083, 25174297, e9730bbe, a5029544. One Picker graduates (d0b24aaa): - ExperimentalFeature.onePicker, the model-picker launch migration and its AppFeatureMigrations call are deleted; "one-picker" and the old experimental-*model-picker keys are retired keys. - The plain/Today picker is removed (PlainModelPickerSheet.kt, ShowAllModelsRow.kt, ModelPickerChip). ModelPickerDetentsSheet and the favourite swipe helpers move to ModelPickerDetentsSheet.kt. OnePickerChip is the only chip and OnePickerSheetHost the only sheet, in the session and in ComposerView. - OnePickerCatalogCache lives on OnePickerController (catalogue reused across opens, prewarmed 0.5 s after the list shuts; closing freezes the rows already built). The panel is built outside the per-frame placement and reads the morph through a lambda, so a morph frame doesn't rebuild the list (25174297, bb4e47f7). - What's New: "New Model Picker" (2026-11-07-03-one-picker), first in the list. Parity fix: the One Picker chip's name roll is weight(1f, fill = false), so only the model name ellipsizes and the level word/arc/chevron keep their width (at font scale 1.15 on a 384 dp phone the level used to drop out). Typing and chrome (d0b24aaa, 3fa29077): - A keystroke is one action: Autocomplete(TextEdited(text, CaretUpdate)), handled by the session through the same draftEdited path as the draft binding. - DraftShape (isEmpty, hasText): the composer snapshot carries it instead of the draft, and ComposerInput reads the draft itself, so typing recomposes only the field. hasPromptContent uses draftShape. - Agent Selection lists agents once per folder (listedDirectory). - Orb clearance geometry is read only in an OrbClearance leaf and at layout, so a moving composer doesn't recompose SessionView. n/a (reasons in the parity rows): Liquid Glass touch handoff and VoiceView glass (20a4df58, 8bd26820), variable blur steps (e9730bbe), SwiftUI redraw probes and invalidation tests (4d167bd3, 8aad7be1, a5b86a4f, 4eb55083), pasteboard image stream (Android asks once when the + menu opens), UIKit text caches, Tuning/playground. Tests: ported ComposerAutocompleteTests+TextEdits (2) and expandingTheComposerAgainDoesNotListAgentsAgain; ExperimentalFeatureTests and AllExperimentsTests follow the graduation. Verified: scripts/check.sh :core :feature:composer :feature:session :feature:settings :feature:voice :feature:drawer :feature:media :app passed (core 147, composer 277, session 784, settings 100 tests); ios-sync.py check: 0 errors.
TranscriptTouchSafety, AgentImageBento, AgentImagePreviewTests and the three SessionFeature rows were each shared by two ports; both halves have landed, so drop their sync: prefix and tick their plan items.
… fixed pause aStreamStrandedOnADeadRouteEndsAsATimeout failed under load (in the s65b port's run and in the merged full check): the test advanced the clock 50 ms after the request landed, so on a busy machine the first line arrived after time moved and the idle deadline counted from later than the loop reaches; and once the deadline passed it allowed only ~0.4 s of real time to wind the stream down. It now waits until the stream reports its first line (through a ServerLinkClient whose noteStreamActivity sets a flag) and gives the wind-down up to 5 s. The behaviour under test is unchanged. Verified: ServerLinkTests passed 8 of 8 runs with all 20 cores busy (one of 5 failed with only the first-line wait).
Ports iOS 24057173, f5636460, 1b6d1a72, 22ddb6a0, 91175fd4, 34a02fc4 and 03adf07a; 32fa40f0 is n/a. - Home persistence off the main thread (24057173): file-backed shared keys now encode on LiveSharedBytes' io thread (SharedBytes.writeEncoded); only the newest waiting value is written and reads return it first. Going to the background flushes the shared store after the transcript cache. - Hidden drawer builds nothing (f5636460): the container provides LocalDrawerHidden; DrawerListModelHolder returns its cached model while hidden after the first build, so the 1.5 s prewarm still pays the first open, but nothing rebuilds per Home change while hidden. The activity ring and ghost-row sweep stop while hidden and run on AmbientClock. HomeFeature.State.drawerSessions (pins + recents in one pass), OpenCodeProjectLookup, DrawerTimestamp.Day, ProjectIconRequest cacheKey computed once, DrawerTunables.registerIfNeeded. - Reveal lands in place (34a02fc4): the first build after a hidden spell syncs shortcut rows as not visible, so changes made while hidden appear without replaying their animation. - Row press waits 80 ms (1b6d1a72) and is dropped if the list is scrolling. - Catch Up drift field draws at 30 fps (22ddb6a0); 0.75x density is n/a (RuntimeShader brush has no cheap lower-resolution target). - Motion roles (03adf07a): drawer release (MotionRelease.shouldCommit, Release spring), shortcut slots, pin drag/lift/drop/move, row status and surfaces, search pill, call button, sidebar, server swap/flow title, Catch Up stack/springs/badge/finish/mode changes, drawer button capsule and dot (Brighten arrival and DrawerDotTunables removed: plain microIn/microOut dot), rolling numbers (layout spring + staggerStep), screenshot flash (Dim), back swipe commit rule. Removed tunables replaced by roles; ServerFlowTunables springs replaced by chainLag (:feature:session). - Tests: new DrawerPerfGateTests (6 of 9 iOS cases); DrawerDotTests; CatchUp/RollingNumber/ScreenCaptureFeedback/Tuning tests updated. - Parity docs and the sync plan updated. Verified: scripts/check.sh :core :feature:drawer :feature:transcript :feature:session :feature:settings :app (pass); ios-sync.py check: 0 errors.
Clears the last shared sync rows (TranscriptTunables, OpenCodeClient+Transcript), ticks the shared TuningTests/TranscriptTunables plan items both ports finished, runs ios-sync advance, and fixes the test totals the parallel ports duplicated (core 152, media 191, session 801). Verified: full scripts/check.sh passes; ios-sync.py check 0 errors.
Generated by ios-sync.py plan/stale: 76 rows marked sync, 1 todo (the default-model What's New entry).
…he camera opens Found on a Galaxy S24 Ultra (Android 17): - Camera: CameraX's physical-camera intrinsicZoomRatio throws UnsupportedOperationException on Samsung's logical camera. It ran inside bind()'s try, so a camera that had bound fine showed "Camera is unavailable". The lens query now runs after a successful bind, a failure only costs the lens buttons, and the telephoto falls back to Camera2 focal lengths, rounded to its nominal whole number (3, not 2.7). - Shutter: sized before openCodeTapTarget, which measures what follows with no minimum, so the empty Box drew only its padding (about 14 dp). It is now Android's 72 dp ring. - Tiles drew their photo over their badges, so neither the pick number nor a video's duration ever showed. - Over a raised keyboard the sheet was squeezed into the space above the keys. iOS draws over the keys; an app can't draw over the IME, so the keyboard now goes down as the sheet opens, and Back or a close brings it back. - The Add pill had a light accent fill with white text and iOS's rolling label. The foot is now a Material 3 Expressive floating toolbar like the system photo picker's: a bare Back arrow, an All Photos text button that becomes a filled primary/onPrimary "Add N Photos" button, and picked tiles spring inset with rounded corners under a numbered circle. Removed: PhotoPillTunables, the animated pill label, PickerTunables.photoAdd and PlusMenuTunables.ALL_PHOTOS_PADDING. Verified: scripts/check.sh :feature:composer :feature:session; on the phone (fast build): sheet opens full-size with the keyboard down, picks show 1/2 badges and the Add button, video badges show, Back returns to the menu with the keyboard, the camera previews with .6/1x/3 lenses, and a capture attaches to the composer.
…ions; voice calls on motion roles fe6cd248: new sessions now start on the server's default model instead of the last session's model: - Home's `lastUsedModel` and the draft's `inheritedModel` are removed. - A draft has no model until the catalogue arrives, then takes `catalog.newSessionModel(modelVariants)`: the server default at the level last picked for it. - `OpenCodeModel.savedLevel` and `OpenCodeModelCatalog.newSessionModel` live in :server (voice needs them and can't depend on :feature:composer). ModelPickerSections reads `savedLevel`. - Voice's `create_session` reads `modelCatalog` (within the latency budget) instead of the Home snapshot, and passes `modelVariants` through `Start`. - New What's New entry `defaultModel`. - Ported iOS tests: two new ModelPicks tests, new/renamed VoiceSessionToolsTests, plus updated NewSessionDraft, ModelDisplayName, SessionSwitch, VoiceLatencyBudget and FloatingCallStage tests. 7b5878d7: the floating call's stages grow on `surface`, shrink on `panelClose` and settle a drag on `release`: - The hang-up lands on `flight`, with bounce capped at 0. - Past the sheet the lift rubber-bands through MotionRubberBand, so a finger catching it holds it where it's drawn. - The window, bloom and control fades use `swap`; the window's exit waits 0.15 s for the call button. - The tag and the mute badge use `micro`. Drift and the composer-top follow use `layout`. - The call log playhead runs at 60 Hz. - VoiceView detents settle on `release` (Reduce Motion now eases instead of snapping), the dim uses `dim` and the pills use `swap`. - Removed the `edge`/`follow`/open/close/land springs and the `feels` presets. `SessionView.kt` orb clearance (read `follow`) now uses `Motion.layout`. - Left for the 258a9424 port: `ModelPickerTunables.restSpring`. Verified: - scripts/check.sh :core :server :feature:composer :feature:session :feature:voice :feature:drawer :feature:settings :app passes (voice 732, session 803, drawer 553, app 158 tests, 0 failures). - ios-sync.py check: 0 errors.
…4fbf3, 258a9424, 01eef583) Port three iOS commits that move the composer, + menu, photo sheet, One Picker, autocomplete, request dock/panel, dictation, background work and session chrome onto the shared motion roles, and drop the bridge aliases. - Composer morph: open/close on panelOpen/panelClose, keyboard on Motion.keyboard; close ends on its animation's completion (generation checked) instead of a settle timer; launchThenFold(landed:) hands the menu back on the photo sheet's landing (no timer). Bridge aliases ComposerMorphTunables.close/photoOpen/photoReturn/photoBack/ photoBackExpanded, PlusCameraTunables.expand/collapse, ComposerKeyboardTunables.keyboardFade and RequestPanelReveal.content/ glass are removed. - Photo sheet (spec swaps only): open panelOpen, Stay settles on release with the throw's speed, toggle on layout, back/folds on panelClose. - + menu, pop, peek, photo pill, flight (0.34 s, exit microOut, row layout), attachment removal, camera (focus/lock/lens on microIn), queued sheet, request collapse (release) and dock (leave on microOut, dropped on completion, no 500 ms sleep), shared location, sent images. - Autocomplete: parameters default from the roles; tunable springs and presets removed; a list pulled past its end rubber-bands (MotionRubberBand) and springs home on endScroll(). - One Picker: springs removed (panelOpen/panelClose, layout detents, release drag settles, Motion.keyboard ride); OnePickerTiming.widthDuration. - Session: request panel folds on panelClose and is dropped on completion (no 350 ms timers); dictation fold lands from its completion (no 320 ms wait), DictationBarPresence(onLeft:) replaces the 400 ms timer; composer column on layout with micro transitions; RequestBarSwap/ComposerSwap on MotionTransition.swap; background work on roles with a release return spring and MotionRubberBand; header, titles (roll on swap), draft projects, server pill, context ring, shell jump button, OrbClearance, page stack reduced fade; title breath period from AmbientClock. - LinkMenu press fades out on Motion.swap instead of a linear 0.18 s. - Core: MotionTransition.roll takes the role for its timing (default layout). Tests: ComposerMorphPhaseTests +launchThenFoldReportsLandingWhileClosing UnlessItReopened; autocomplete test renamed to searchUpdatesCommitAtOnceAndSettleOnTheCollapseRole plus aListPulledPastItsEndRubberBandsAndSpringsHome and reduceMotionHoldsTheListAtItsEnd; AttachmentMenuPressTests theMenuUsesItsTunedHoldAndThePanelRoles; PhotoFlightTests on the roles; TuningTests without keyboardFade; BackgroundWorkTests allows 2.5 pt/frame. n/a: glass/UIKit-only parts (paste control delay, chip button style, AmbientRate frame intervals, MotionXRay, tuning registration keys). ModelPickerTunables' 258a9424 part is ported; its 7b5878d7 part and plan row stay for the voice-roles port. Verified: scripts/check.sh :core :feature:composer :feature:session :feature:media :feature:voice :feature:drawer :feature:settings :devtools :app passes; ios-sync.py check reports 0 errors.
Ticks the last shared plan row (ModelPickerTunables: both 7b5878d7 and 258a9424 halves ported; the unused restSpring alias removed, as on iOS), advances sync.json to 01eef583 and sets the composer test total to 280. Verified: full scripts/check.sh passes; ios-sync.py check 0 errors; test counts match every module's parity total.
…83 sync Brings in the release workflow (Play uploads only on v* tags), the Play photo policy change, the QA fixes and the navigation-bar spacing for the + menu. Resolutions: - Photos follow main: no READ_MEDIA permissions, the live PhotoLibraryClient reports Unavailable and + → Photos opens the system picker. The photo sheet code stays, unreachable. PhotoRequestGate stays replaced by OneShotRequestGate. - The + menu's navigation-bar inset moved onto AttachmentMenuMeasure (the overlay it was on is gone) and into PlusMenuPlacement.foot. - LocalDrawerVisible (main) folded into LocalDrawerHidden (ours); the activity ring keeps main's TalkBack check on the ambient clock. - Catch Up finish keeps main's modal drawer handling on our motion roles (swap enter/exit). - Transcript row exits (main) keep RowEntrance.EXIT_DURATION alongside the role-driven entrances; LiveTranscript records the cursor as main does and keeps the parse cache. - Title rolls, the draft list exit and the composer swipe/edit paths keep both sides. - ServerLinkTests.expectTimeout keeps stepping the clock until the stream ends (up to 100 s): the watchdog wakes on another thread and can sleep from a clock read taken before a jump. Parity docs merged row by row; test totals recounted. Verified: full scripts/check.sh passes; ios-sync.py check 0 errors.
Tarquinen
added a commit
that referenced
this pull request
Nov 9, 2026
…UI work Brings Ryan's #3, #4, #6 and #7 into the Material 3 branch through PR #5. Conflicts kept both sides: main's TalkBack, touch and focus fixes with this branch's Material styling (Jump to Latest as a small FAB on main's touch tracking, the Export submenu in main's non-focusable menu, the level word ellipsizing inside the outlined model chip, the Catch Up swipe glyph on its tone colour, the transcript's row exits with the soft bottom edge). Verified: scripts/check.sh passes for every module; ios-sync check 0 errors; parity test totals match Gradle.
…iOS 01eef583 logic Brings the iOS sync up to date with main (desktop restyle, Android 13/14 support, QA fixes). Every conflict keeps main's visuals and this branch's behaviour. Notable resolutions: - AppFeaturePairing.kt: main's QA FB-02 fix (validatePairing decodes with OpenCodePairingLink.decodeCopied) carried over by hand, as this branch moved validatePairing out of AppFeatureServers.kt; AppFeatureServers.kt keeps this branch's pasteProblem -> pairingProblem. - PlainModelPickerSheet.kt: deleted (the One Picker is the model picker); main's One Picker restyle (popover surface, hairline, sheet handle, text field container, 12/16 dp radii) survives. - AppView.kt: main's mono copy-command text (calt 0, one Button node) and TalkBack title focus, plus this branch's swap cross-fade and layout-role scroll to top. - AttachmentMenu.kt: card picker removed (this branch) with main's popover menu (10 dp radius, 12 dp corner, 4 dp padding, Medium callout labels). - AutocompleteTunables.kt: this branch's tunables without presets, with main's 12 dp composer corner (not 28). - WhatsNewView.kt: this branch's AmbientTimeline field on main's card radius (not 20 dp) and OpenCodeSwitch. - ComposerViews.kt: main's neutral-to-send cross-fade on the swap role, this branch's tunables. - FloatingCall.kt: Server Voice graduation with main's controlFill and swap role; glyph dims with the plate. - MarkdownBand.kt: this branch's inset block, still taking bandModifier. - Text fields: main's string placeholders/labels plus this branch's clear buttons. - docs/parity: rows merged word by word (this branch's iOS line counts and sync notes, main's QA and Android 13 notes); voice total 736. Verified: python3 scripts/ios-sync.py check (854 rows, 0 errors, the 11 warnings already on both parents); scripts/check.sh on the Android VM (assemble, lint, unit tests for every module) passes, no NewApi findings.
The iOS 01eef583 sync brought three surfaces that merged without conflict but still used raw Material styling. Restyled them with core/ui tokens, logic unchanged: - Photo sheet foot: the floating toolbar moves from an M3 surfaceContainerHigh capsule to the desktop floating surface (12 dp panel, hairline, raised shadow). All Photos is a neutral desktop button (light fill, hairline, control shape); Add N Photos is accent-filled with the accent's contrast foreground, subheadline semibold, instead of the M3 primary capsule. The tile selection badge uses the accent instead of colorScheme.primary (position and inset from #5 kept). - Connecting via… caption: control shape with the call's hairline instead of a round capsule on the call surface. - Motion Playground: stages on the desktop floating surface (12 dp panel, hairline), OpenCodeSwitch, OpenCodeTextStyles and theme text colours; example tiles use card radius with the neutral fill and hairline, accent/signal fills instead of primary/secondaryContainer/tertiary, 16-20 dp corners gone. Parity rows (composer, devtools, voice) updated. Verified: vm.sh check :devtools :feature:composer :feature:voice (BUILD SUCCESSFUL).
…show-more fix Brings in #24 (a pushed page leaves a rightward swipe to a horizontal scroller that can still scroll back) and #25 (no black box under a long collapsed user message). Both merged cleanly in code; docs/parity/session.md keeps #5's iOS 01eef583 line counts and notes and adds main's scrollerClaims note to the SessionPageStack row. Verified: python3 scripts/ios-sync.py check (854 rows, 0 errors); scripts/check.sh :feature:transcript :feature:session on the Android VM.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports iOS
3d50fd74→01eef583. Merged withmainatb1c62c0f, so it keeps main's desktop design, Android 13 support (minSdk 33) and QA fixes.User-facing
Developer
core/motion): shared roles (press,swap,layout, …),MotionTransition, and the Motion Playground in Developer › Playgrounds.validatePairingmoved toAppFeaturePairing.ktand still uses main'sdecodeCopiedpasted-link fix (PairingPasteTests).core/uitokens: the Motion Playground, the photo sheet's foot and badges, and the Connecting via… caption (control radius with a hairline instead of a capsule).docs/parity/sync.jsonare synced to iOS01eef583.scripts/ios-sync.py checkreports 0 errors.Verified:
scripts/check.sh(full, Android VM), with noNewApilint findings. Emulator smoke test against session-lab in light and dark, with an empty crash log. Before/after screenshots are inshots/pr5-merge/.