Repository navigation
feat(tui): add logo setting to hide or replace the home logo #65358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
martinwangjian
wants to merge
2
commits into
anomalyco:dev
Choose a base branch
from
martinwangjian:feat/tui-logo-setting
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import { expect, test } from "bun:test" | ||
| import { createAppFixture } from "./fixture/app" | ||
|
|
||
| // The first row of the built-in home logo. | ||
| const BUILT_IN_LOGO = "█▀▀█ █▀▀█ █▀▀█ █▀▀▄" | ||
|
|
||
| test("logo lines from the config replace the built-in home logo", async () => { | ||
| await using setup = await createAppFixture({ | ||
| config: { animations: false, logo: ["ACME CODE", "internal build"] }, | ||
| }) | ||
| await setup.ready | ||
| await setup.waitForFrame((frame) => frame.includes("ACME CODE") && frame.includes("internal build")) | ||
| expect(setup.captureCharFrame()).not.toContain(BUILT_IN_LOGO) | ||
| }) | ||
|
|
||
| test("logo false hides the home logo and keeps the home screen", async () => { | ||
| await using setup = await createAppFixture({ config: { animations: false, logo: false } }) | ||
| await setup.ready | ||
| await setup.waitForFrame((frame) => frame.includes("ctrl+p commands")) | ||
| expect(setup.captureCharFrame()).not.toContain(BUILT_IN_LOGO) | ||
| }) | ||
|
|
||
| test("without a logo setting the built-in home logo is shown", async () => { | ||
| await using setup = await createAppFixture({ config: { animations: false } }) | ||
| await setup.ready | ||
| await setup.waitForFrame((frame) => frame.includes(BUILT_IN_LOGO)) | ||
| }) | ||
|
|
||
| test("custom logo lines render as plain text", async () => { | ||
| await using setup = await createAppFixture({ config: { animations: false, logo: ["acme_code, v1 ^~"] } }) | ||
| await setup.ready | ||
| await setup.waitForFrame((frame) => frame.includes("acme_code, v1 ^~")) | ||
| }) | ||
|
|
||
| test("a custom logo wider than the terminal is hidden", async () => { | ||
| const wide = "ACME".repeat(20) | ||
| await using setup = await createAppFixture({ width: 60, config: { animations: false, logo: [wide] } }) | ||
| await setup.ready | ||
| await setup.waitForFrame((frame) => frame.includes("ctrl+p")) | ||
| const frame = setup.captureCharFrame() | ||
| expect(frame).not.toContain("ACMEACME") | ||
| expect(frame).not.toContain(BUILT_IN_LOGO) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.