Repository navigation
fix: honour overridden array iterators in destructuring and spread - #7
Merged
Merged
Conversation
User decisions: - Honour overridden array iterators with a single protector flag, keeping the fast path for code that doesn't override them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrays were iterated directly, ignoring a program's replacement of
Array.prototype[Symbol.iterator]or the built-in iterators'next.Protector(src/runtime/objects.ts) is cleared, for the rest of the run, by any set/define/accessor/delete of those two keys on those two prototypes (one guard check in the already-slow property-write paths).Arr/Arguments/Bytesiterator()andbuiltinCursorfor built-in array iterators fall back to the iterator protocol when it is cleared, or when an array has its own[Symbol.iterator]or another prototype. This covers destructuring, spread,for...of,yield*,Array.from, Map/Set/Promise intake.Protectorrecord).