Repository navigation
perf(runtime): look up mounted nodes in a dense table bounded by the tree - #1069
Merged
Merged
Conversation
…f the tree place and prune still rebuild the index at the same points, and exiting nodes are still appended. Sequential live ids use direct slots; colliding live ids from different generations use an overflow map. Neither the table nor overflow scales with the number of paths a window has retired. No commit or paint pass skips nodes.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
# Conflicts: # crates/rune/src/runtime.rs # crates/rune/src/runtime/commit/memo_reuse.rs # crates/rune/src/runtime/commit/prune.rs
Member
Author
|
Brought up to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mounted nodes are looked up in a dense table sized by the tree, not in a hash map. Rebuilding the index costs a third as much on large trees.
What changes
NodeIndex(runtime/node_index.rs) replacesHashMap<NodeId, usize>for node positions. Sequential live IDs go straight to a slot without hashing. Live IDs from older generations that share a slot go to an overflow map.placeand pruning rebuild the index at the same points, and exiting nodes are still appended. No commit or paint pass skips nodes.Evidence
These are rebuild costs on one quiet blade window, not key-frame savings.
15f33064. Windows full suite: see the comment below before merge.