Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Refresh handling must preserve missing-instance behavior after the instance is deleted.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This pull request improves NIC attachment state handling and targeted refresh behavior.
Changes:
- Populates NIC state from the attachment response.
- Refreshes NICs using instance and NIC IDs.
- Preserves omitted instance IDs and handles missing or duplicate responses.
File summaries
| File | Description |
|---|---|
cloudstack/resource_cloudstack_nic.go |
Revises NIC creation, refresh, and state population logic. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+103
to
105
| l, err := cs.Nic.ListNics(p) | ||
| if err != nil { | ||
| return err |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes NIC attachment failures by populating the state directly from the
addNicToVirtualMachineresponse instead of immediatly refreshing the instance (this can cause drift).NIC refreshes now use
listNicswith the instance and NIC IDs. The configured instance ID is preserved when the API response omits it, and missing or duplicate NIC responses are handled explicitly.