Persist and expose effective network rate for NIC, Network and compute offering by sudo87 · Pull Request #13325 · apache/cloudstack

sudo87 · 2026-06-03T09:56:15Z

Description

This PR exposes the effective network rate (bandwidth throttling) configured for NICs and guest networks through API responses and UI.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2026-06-03T10:30:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.71%. Comparing base (dc0ba1c) to head (4c8b4ef).
⚠️ Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (dc0ba1c) and HEAD (4c8b4ef). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (dc0ba1c) HEAD (4c8b4ef)

unittests 1 0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #13325       +/-   ##
=============================================
- Coverage     19.89%    3.71%   -16.19%     
=============================================
  Files          6371      487     -5884     
  Lines        576829    41992   -534837     
  Branches      70627     7942    -62685     
=============================================
- Hits         114778     1558   -113220     
+ Misses       449507    40208   -409299     
+ Partials      12544      226    -12318

Flag	Coverage Δ
uitests	`3.71% <ø> (ø)`
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…e offering

github-actions · 2026-06-08T07:10:22Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

# Conflicts: # server/src/main/java/com/cloud/vm/UserVmManagerImpl.java # ui/src/config/section/network.js

- Add network_rate column to nics table (schema-42300to42400.sql) - Add DB upgrade path: Upgrade42300to42400 registered in DatabaseUpgradeChecker - Add network_rate field and getter/setter to NicVO - Set network_rate on NicVO in NetworkOrchestrator.allocateNic() where rate is already computed, eliminating secondary per-NIC update calls - Add getNetworkRate() to Nic interface so ApiResponseHelper.createNicResponse can call result.getNetworkRate() without casting or extra DB queries - Add nic_network_rate to user_vm_view and UserVmJoinVO so listVirtualMachines reads rate from the join without extra per-NIC findNicById calls - Update UserVmJoinDaoImpl to use uvo.getNicNetworkRate() directly - Expose network_rate in NicResponse as Integer (null = unlimited) - Refresh NIC rates on VM start via refreshNicNetworkRates in UserVmManagerImpl

sudo87 · 2026-09-04T11:27:37Z

@blueorangutan package

blueorangutan · 2026-09-04T11:28:05Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-09-04T12:15:36Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19103

github-actions · 2026-09-07T09:45:12Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sudo87 · 2026-09-07T16:55:53Z

@blueorangutan package

blueorangutan · 2026-09-07T16:58:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-09-07T17:47:49Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19139

sudo87 · 2026-09-14T07:01:21Z

@blueorangutan package

blueorangutan · 2026-09-14T07:02:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-09-14T07:48:52Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19236

…orkOffering APIs Align networkrate field type and unlimited semantics (-1) across NetworkResponse and NicResponse with the existing NetworkOfferingResponse convention, instead of using a String unlimited value or omitting the field entirely.

Instance NICs now derive rate solely from the VM's own offering. VR guest interfaces check the router's own system offering first, then fall back to the network offering. Persist rate once in prepareNic() for all VM types. Also surface NIC network rate on listRouters. Existing NICs won't reflect the new precedence until their VM/router is restarted; a DB backfill for pre-existing NICs is tracked as a separate follow-up.

…gration Add an upgrade-time backfill for nics.network_rate and the network_details networkrate entry, frozen to pre-feature precedence so existing bandwidth doesn't change. Also refresh network_details rate during migrateGuestNetwork, and add unit tests for getNetworkRate precedence.

sudo87 · 2026-09-16T11:14:09Z

@blueorangutan package

blueorangutan · 2026-09-16T11:16:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-09-16T12:04:16Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19262

boring-cyborg Bot added component:api component:networking component:orchestration component:UI labels Jun 3, 2026

sudo87 changed the title ~~persist and expose effective network rate for NIC, Network and compute offering~~ Persist and expose effective network rate for NIC, Network and compute offering Jun 3, 2026

sudo87 marked this pull request as draft June 3, 2026 09:56

bernardodemarco requested a review from hsato03 June 3, 2026 12:23

persist and expose effective network rate for NIC, Network and comput…

498b69b

…e offering

github-actions Bot added the status:has-conflicts label Jun 8, 2026

weizhouapache added this to the 4.24.0 milestone Jun 29, 2026

DaanHoogland added this to CloudStack Testing Aug 31, 2026

github-project-automation Bot moved this to Backlog in CloudStack Testing Aug 31, 2026

DaanHoogland moved this from Backlog to conflict/waiting for author in CloudStack Testing Aug 31, 2026

Merge branch 'main' into networkThrottling

c8ac2a0

# Conflicts: # server/src/main/java/com/cloud/vm/UserVmManagerImpl.java # ui/src/config/section/network.js

sudo87 force-pushed the networkThrottling branch from 35bcb26 to c8ac2a0 Compare September 4, 2026 06:14

github-actions Bot removed the status:has-conflicts label Sep 4, 2026

github-actions Bot added the status:has-conflicts label Sep 7, 2026

Merge branch 'main' into networkThrottling

fb7cce0

github-actions Bot removed the status:has-conflicts label Sep 7, 2026

fix ui build due to merge conflict

b684b88

sudo87 added 2 commits September 8, 2026 12:56

Merge branch 'main' into networkThrottling

cd349f5

Merge branch 'main' into networkThrottling

469d391

sudo87 force-pushed the networkThrottling branch from 5b71a1b to afd59d9 Compare September 16, 2026 04:08

sudo87 force-pushed the networkThrottling branch from afd59d9 to 71d49b8 Compare September 16, 2026 04:13

sudo87 added 3 commits September 16, 2026 13:39

ui: show Unlimited instead of -1 for network rate

817c2f9

Fix backfill NPE and statement auto-close bug found via e2e testing

4c8b4ef

Uh oh!

Conversation

sudo87 commented Jun 3, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jun 8, 2026

Uh oh!

sudo87 commented Sep 4, 2026

Uh oh!

blueorangutan commented Sep 4, 2026

Uh oh!

blueorangutan commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 7, 2026

Uh oh!

sudo87 commented Sep 7, 2026

Uh oh!

blueorangutan commented Sep 7, 2026

Uh oh!

blueorangutan commented Sep 7, 2026

Uh oh!

sudo87 commented Sep 14, 2026

Uh oh!

blueorangutan commented Sep 14, 2026

Uh oh!

blueorangutan commented Sep 14, 2026

Uh oh!

sudo87 commented Sep 16, 2026

Uh oh!

blueorangutan commented Sep 16, 2026

Uh oh!

blueorangutan commented Sep 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Jun 3, 2026 •

edited

Loading