Skip to content

chore: remove deprecated Parquet APIs past the API health policy - #25202

Open
WaterWhisperer wants to merge 1 commit into
apache:mainfrom
WaterWhisperer:remove-deprecated-parquet-apis
Open

chore: remove deprecated Parquet APIs past the API health policy#25202
WaterWhisperer wants to merge 1 commit into
apache:mainfrom
WaterWhisperer:remove-deprecated-parquet-apis

Conversation

@WaterWhisperer

@WaterWhisperer WaterWhisperer commented Sep 11, 2026

Copy link
Copy Markdown

Which issue does this PR close?

Rationale for this change

The deprecated Parquet APIs have passed the API health policy.

What changes are included in this PR?

  • Remove the deprecated fetch_parquet_metadata, fetch_statistics, and statistics_from_parquet_meta_calc functions.
  • Remove the deprecated ParquetSource::predicate method.
  • Remove the associated unused imports and test.

What is the testing strategy for this PR?

No new tests are added because this only removes deprecated apis.

Tested by:

./dev/rust_lint.sh

Are there any user-facing changes?

Yes. It's a breaking Rust API change because public deprecated APIs are removed.

@github-actions github-actions Bot added the datasource Changes to the datasource crate label Sep 11, 2026
@github-actions

Copy link
Copy Markdown

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details
     Cloning apache/main
    Building datafusion-datasource-parquet v55.0.0 (current)
       Built [  59.253s] (current)
     Parsing datafusion-datasource-parquet v55.0.0 (current)
      Parsed [   0.039s] (current)
    Building datafusion-datasource-parquet v55.0.0 (baseline)
       Built [  51.279s] (baseline)
     Parsing datafusion-datasource-parquet v55.0.0 (baseline)
      Parsed [   0.037s] (baseline)
    Checking datafusion-datasource-parquet v55.0.0 -> v55.0.0 (no change; assume patch)
     Checked [   0.235s] 223 checks: 221 pass, 2 fail, 0 warn, 31 skip

--- failure function_missing: pub fn removed or renamed ---

Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_missing.ron

Failed in:
  function datafusion_datasource_parquet::file_format::fetch_parquet_metadata, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/9aa108929b2879c28f04d56b5bbe8b37c52f4a4a/datafusion/datasource-parquet/src/file_format.rs:652
  function datafusion_datasource_parquet::fetch_parquet_metadata, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/9aa108929b2879c28f04d56b5bbe8b37c52f4a4a/datafusion/datasource-parquet/src/file_format.rs:652
  function datafusion_datasource_parquet::file_format::fetch_statistics, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/9aa108929b2879c28f04d56b5bbe8b37c52f4a4a/datafusion/datasource-parquet/src/file_format.rs:675
  function datafusion_datasource_parquet::fetch_statistics, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/9aa108929b2879c28f04d56b5bbe8b37c52f4a4a/datafusion/datasource-parquet/src/file_format.rs:675
  function datafusion_datasource_parquet::file_format::statistics_from_parquet_meta_calc, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/9aa108929b2879c28f04d56b5bbe8b37c52f4a4a/datafusion/datasource-parquet/src/file_format.rs:697
  function datafusion_datasource_parquet::statistics_from_parquet_meta_calc, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/9aa108929b2879c28f04d56b5bbe8b37c52f4a4a/datafusion/datasource-parquet/src/file_format.rs:697

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron

Failed in:
  ParquetSource::predicate, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/9aa108929b2879c28f04d56b5bbe8b37c52f4a4a/datafusion/datasource-parquet/src/source.rs:399

     Summary semver requires new major version: 2 major and 0 minor checks failed
    Finished [ 112.386s] datafusion-datasource-parquet

@github-actions github-actions Bot added the auto detected api change Auto detected API change label Sep 11, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.94%. Comparing base (224cc56) to head (5151e08).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25202      +/-   ##
==========================================
+ Coverage   81.91%   81.94%   +0.02%     
==========================================
  Files        1132     1133       +1     
  Lines      421314   423483    +2169     
  Branches   421314   423483    +2169     
==========================================
+ Hits       345135   347012    +1877     
- Misses      55771    55880     +109     
- Partials    20408    20591     +183     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nuno-faria nuno-faria left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WaterWhisperer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto detected api change Auto detected API change datasource Changes to the datasource crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated Parquet metadata / statistics APIs that are past the API health policy

3 participants