Backport HBASE-29672 to branch-2 - Handle runtime comparison failures during filtering gracefully - #8647
Open
droudnitsky wants to merge 2 commits into
Open
Backport HBASE-29672 to branch-2 - Handle runtime comparison failures during filtering gracefully#8647droudnitsky wants to merge 2 commits into
droudnitsky wants to merge 2 commits into
Conversation
added 2 commits
September 10, 2026 08:29
…fully Backport of HBASE-29672 to branch-2. Filters that accept a user-supplied ByteArrayComparable now wrap any RuntimeException thrown while applying the comparator in an HBaseIOException, so it surfaces as a clear remote exception instead of escaping as an unexpected throwable at the RpcServer layer. branch-2 differences from the master patch: * CompareFilter retains the deprecated CompareOp overloads of compareRow/compareFamily/compareQualifier/compareValue. These are left untouched; only the CompareOperator variants wrap comparator failures. * The deprecated filterKeyValue(Cell) delegates in FamilyFilter, QualifierFilter, ValueFilter, DependentColumnFilter and SingleColumnValueFilter now declare throws IOException, since the filterCell(Cell) they delegate to does. Filter.filterKeyValue(Cell) already declares it, so this is consistent with the base class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7397 to branch-2. Not a clean cherry-pick — conflicts in
CompareFilterbecause branch-2 keeps the deprecatedCompareOpoverloads that master removed. Kept both.Only other delta:
throws IOExceptionadded to the deprecatedfilterKeyValue(Cell)delegates inFamilyFilter,QualifierFilter,ValueFilter,DependentColumnFilterandSingleColumnValueFilter. They callfilterCell, which now throws, so it doesn't compile otherwise.Filter.filterKeyValuealready declares it.The deprecated
compare{Row,Family,Qualifier,Value}(CompareOp, ...)overloads are left unwrapped — adding a checked exception to them would break source compat in 2.x. No in-tree callers.