HIVE-29685: Fix LLAP UI status for non-YARN deployments by Manya0407 · Pull Request #6656 · apache/hive

Manya0407 · 2026-07-29T05:16:06Z

What changes were proposed in this pull request?

1.This PR fixes the HiveServer2 LLAP status page (/llap.html, backed by GET /llap) on non-YARN deployments such as Kubernetes and Docker. Today LlapServlet delegates to LlapStatusServiceDriver, which only queries YARN for the LLAP application. On K8s/Docker, LLAP daemons register in ZooKeeper instead of YARN, so the driver returns APP_NOT_FOUND and the UI never shows running instances.
2.The main change is config-based routing in LlapStatusServiceDriver: when the deployment is detected as non-YARN (via hive.server2.tez.use.external.sessions=true, tez.am.framework.mode=STANDALONE_ZOOKEEPER, or the override hive.llapcli.status.use-registry), status is populated from the LLAP ZK registry instead of YARN. For those deployments, worker UUIDs are used as container IDs when YARN container IDs are absent. The YARN path is unchanged for classic YARN LLAP.
3.This PR also fixes runningThresholdAchieved not being set for servlet/one-shot callers by calling updateRunningThresholdAchieved() after a successful registry or YARN status lookup. LlapServlet now returns HTTP 500 when status lookup fails. On the UI side, it removes references to missing boolean PNG assets in llap.js, adds a defensive guard in json.human.js so bool icons are only rendered for valid /static/ paths, and adds cache-buster query params in llap.html. Unit tests are added in TestLlapStatus

Why are the changes needed?

On Kubernetes and Docker, LLAP does not run as a YARN application. Daemons register in ZooKeeper, but the status driver only looked up YARN and returned early with APP_NOT_FOUND before consulting the registry. That broke /llap.html for operators running LLAP on K8s/Docker — they could not see cluster state, instance counts, or daemon web URLs from HiveServer2.
The runningThresholdAchieved field was also never set for the servlet path, so the UI always showed false even when all daemons were up. The broken boolean icon beside runningThresholdAchieved is a separate pre-existing UI bug (missing PNG assets since HIVE-13467); this PR fixes that as well so the page renders cleanly.

Does this PR introduce any user-facing change?

Yes. On non-YARN LLAP deployments, /llap.html and GET /llap now report the correct state (RUNNING_ALL / RUNNING_PARTIAL instead of APP_NOT_FOUND), show live instance counts and daemon web URLs from the registry, and set runningThresholdAchieved to true when the running threshold is met. On YARN LLAP deployments, behavior is unchanged. When status lookup fails, the servlet returns HTTP 500 instead of 200 with incomplete JSON. The LLAP UI no longer shows a broken image icon before boolean fields; it displays plain true/false text instead.

Before :

After:

How was this patch tested?

1.Unit tests were added in TestLlapStatusRegistryFallback.java covering registry instance creation (worker identity vs YARN container ID), state updates from instance counts, config-based detection of registry vs YARN status lookup, and runningThresholdAchieved logic. These were run with mvn test -pl llap-server -Dtest=TestLlapStatusRegistryFallback.
2.End-to-end testing used the Docker LLAP stack in packaging/src/docker/ with ./start-hive.sh --llap and a locally built apache/hive:4.3.0-SNAPSHOT image

sonarqubecloud · 2026-07-29T06:29:24Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull request overview

This PR fixes the HiveServer2 LLAP status endpoint/UI (GET /llap and /llap.html) for non-YARN deployments (e.g., Kubernetes/Docker) by routing status discovery to the LLAP ZooKeeper registry when appropriate, while keeping the existing YARN path intact. It also cleans up the UI’s boolean rendering behavior and adds unit coverage for the new registry-based helpers.

Changes:

Add config-based routing in LlapStatusServiceDriver to populate status from the LLAP registry for non-YARN deployments, including running-threshold updates.
Harden/adjust LLAP UI rendering (avoid missing boolean PNG assets; add cache-busting query params).
Add unit tests covering registry fallback behavior and helper logic.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
service/src/resources/hive-webapps/static/js/llap.js	Disables boolean image rendering for LLAP UI JSON viewer options.
service/src/resources/hive-webapps/static/js/json.human.js	Adds defensive checks around boolean image rendering (path validation) and disables images when invalid.
service/src/resources/hive-webapps/hiveserver2/llap.html	Adds cache-buster query params for JS assets.
service/src/java/org/apache/hive/http/LlapServlet.java	Returns HTTP 500 when LLAP status lookup fails (instead of 200 with incomplete JSON).
llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java	Implements registry-based status path + shared helpers; ensures `runningThresholdAchieved` is computed after successful lookups.
llap-server/src/test/org/apache/hadoop/hive/llap/cli/status/TestLlapStatusRegistryFallback.java	Adds unit tests for registry-only instance creation, state computation, config detection, and running-threshold logic.

Suppressed comments (1)

service/src/resources/hive-webapps/static/js/json.human.js:445

Using String.prototype.startsWith here can break option validation in older browsers that don't support it (e.g., IE 11). Use an ES5-safe prefix check so the bool image option handling doesn't throw at runtime.

            if(boolOptions.showImage){
                if(!boolOptions.img || !boolOptions.img.true || !boolOptions.img.false
                    || !('' + boolOptions.img.true).startsWith('/static/')
                    || !('' + boolOptions.img.false).startsWith('/static/')){
                    boolOptions.showImage = false;

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Manya0407 · 2026-08-31T09:44:56Z

  private static final EnumSet<State> NO_YARN_SERVICE_INFO_STATES = EnumSet.of(
-      State.APP_NOT_FOUND, State.COMPLETE, State.LAUNCHING);
+      State.COMPLETE, State.LAUNCHING);


Added an explicit early return when state is APP_NOT_FOUND on the YARN path, so we don’t continue into YARN Service/registry calls. K8s/Docker still uses the registry-only path via usesRegistryBasedLlapStatus() at the top of run().

Manya0407 · 2026-08-31T09:45:11Z

+            if (boolOpt.showImage && boolOpt.img && boolOpt.img.true && boolOpt.img.false
+                && ('' + boolOpt.img.true).startsWith('/static/')
+                && ('' + boolOpt.img.false).startsWith('/static/')) {


Replaced .startsWith('/static/') with .indexOf('/static/') === 0 in both places for IE11 compatibility.

Manya0407 · 2026-08-31T09:45:33Z

        if (ret == ExitCode.SUCCESS) {
          driver.outputJson(writer);
+        } else {
+          response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
        }


Added Cache-Control: no-store on the error path so proxies don’t cache failed status responses.

tanishq-chugh · 2026-08-20T19:07:24Z

+      if (NO_YARN_SERVICE_INFO_STATES.contains(appStatusBuilder.getState())) {
+        updateRunningThresholdAchieved(appStatusBuilder, cl.getRunningNodesThreshold());


is updateRunningThresholdAchieved call needed here? This condition should be true only when state is Complete or Launching, but i believe in that case updateRunningThresholdAchieved just returns ?

Call was a no-op here since the method only acts on RUNNING_PARTIAL/RUNNING_ALL. Removed it.

tanishq-chugh · 2026-08-20T19:13:05Z

  private ExitCode populateAppStatusFromLlapRegistry(AppStatusBuilder appStatusBuilder, long watchTimeoutMs)
      throws LlapStatusCliException {
+    return populateAppStatusFromLlapRegistry(appStatusBuilder, watchTimeoutMs, false);
+  }


there is no usages of this old definition, i think it can be removed.

Removed the unused 2-arg wrapper; run() calls the 3-arg version directly.

…r YARN path, remove dead code, set no-store on servlet errors, and use IE11-safe path checks in json.human.js.

tanishq-chugh · 2026-09-09T13:09:58Z

+    <script src="/static/js/json.human.js?v=1"></script>
+    <script src="/static/js/llap.js?v=2"></script>


What is the reason for this change?

Added ?v= during testing because browsers kept serving old cached llap.js/json.human.js (still pointing at missing PNGs), so the UI looked broken until a hard refresh. It's a standard cache-bust for upgrades — doesn't break anything or change how caching works.

That said, the actual fix is in the JS changes, so it's optional. As Per feedback I've removed the cache-busting params in the latest push

tanishq-chugh · 2026-09-09T13:17:29Z

      }
    } catch (Exception e) {
      LOG.error("Caught exception while processing llap status request", e);
      response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);


Should we consider adding same Cache-Control: no-store in case of error here?

Added Cache-Control: no-store in the catch block as well, same as the non-success path.

sonarqubecloud · 2026-09-11T09:01:50Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

asf-ci-hive added the tests pending label Jul 29, 2026

asf-ci-hive added tests passed and removed tests pending labels Jul 29, 2026

ayushtkn requested a lite review from Copilot August 20, 2026 10:53

Copilot started reviewing on behalf of ayushtkn August 20, 2026 10:55 View session

Copilot AI reviewed Aug 20, 2026

View reviewed changes

tanishq-chugh reviewed Aug 25, 2026

View reviewed changes

asf-ci-hive added tests pending tests failed and removed tests passed tests pending labels Aug 31, 2026

ManyaMehrotra added 2 commits August 31, 2026 15:07

HIVE-29685: Fix LLAP UI status for non-YARN deployments

249a48e

HIVE-29685: Address review comments:Short-circuit on APP_NOT_FOUND fo…

1846842

…r YARN path, remove dead code, set no-store on servlet errors, and use IE11-safe path checks in json.human.js.

Manya0407 force-pushed the HIVE-29685-llap-ui-registry-status branch from 3cb47bb to 1846842 Compare August 31, 2026 09:42

asf-ci-hive added tests pending tests passed and removed tests failed tests pending labels Aug 31, 2026

Manya0407 requested a review from tanishq-chugh August 31, 2026 14:09

asf-ci-hive added tests pending tests unstable tests passed and removed tests passed tests pending tests unstable labels Aug 31, 2026

tanishq-chugh reviewed Sep 9, 2026

View reviewed changes

HIVE-29685: Add Cache-Control: no-store on LlapServlet exception path

b648743

asf-ci-hive added tests pending tests passed and removed tests passed tests pending labels Sep 10, 2026

HIVE-29685: Address review feedback on control flow and cache busting

f76c03d

asf-ci-hive added tests pending and removed tests passed labels Sep 11, 2026

asf-ci-hive added tests passed and removed tests pending labels Sep 11, 2026

		if (NO_YARN_SERVICE_INFO_STATES.contains(appStatusBuilder.getState())) {
		updateRunningThresholdAchieved(appStatusBuilder, cl.getRunningNodesThreshold());

		<script src="/static/js/json.human.js?v=1"></script>
		<script src="/static/js/llap.js?v=2"></script>

Uh oh!

Conversation

Manya0407 commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

sonarqubecloud Bot commented Jul 29, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Sep 11, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Manya0407 commented Jul 29, 2026 •

edited

Loading