[WIP] HIVE-30042: Fix LLAP encoded/vectorized read path for TIMESTAMP WITH LOCAL TIME ZONE on ORC tables - #6776
Open
vikramahuja1001 wants to merge 2 commits into
Open
Conversation
…lure on ORC tables
…LOCAL TIME ZONE on ORC tables
vikramahuja1001
changed the title
vikramahuja1001
changed the title
|
| result = (TimestampLocalTZWritable) previous; | ||
| } | ||
| TimestampColumnVector tcv = (TimestampColumnVector) vector; | ||
| result.set(new TimestampTZ(tcv.time[row] / 1000, tcv.nanos[row], timeZone)); |
Contributor
There was a problem hiding this comment.
Math.floorDiv() should be used here as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Check https://issues.apache.org/jira/browse/HIVE-30042 and #6761 for more details
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add tests in .q file