THRIFT-5242: Add Homebrew installation instructions for macOS

[slachiewicz]

JIRA: THRIFT-5242
Client: doc

doc/install/os_x.md now covers the pre-built compiler first, brew install thrift, and then building the compiler from source with Homebrew-provided tools.

• The Homebrew line installs automake libtool pkg-config cmake bison flex, the set the macOS CI job uses, so ./bootstrap.sh finds libtoolize and configure.ac finds the pkg-config macros.
• Both recipes build only the compiler, which is what the page promises: --disable-libs --disable-tests for Autotools and -DBUILD_LIBRARIES=OFF -DBUILD_TESTING=OFF -DBUILD_TUTORIALS=OFF for CMake. Neither needs Boost, libevent or OpenSSL; one sentence tells readers who also want the C++ library what to add.
• The CMake recipe builds into cmake-build, since cmake -B build would reuse the repository's own build/ directory, which holds the CMake modules.
• A note explains that the bison shipped with macOS is 2.3 and cannot process the grammar, and that Homebrew's is keg-only, so each recipe points at it explicitly.
• External links move to HTTPS.

Verified: both recipes run as written on macOS 15 (Apple Silicon) → thrift -version prints 0.25.0 from each build. Limits of that check: the sudo … install steps ran into a scratch prefix, so the /usr/local permissions were not exercised; flex on the test machine came from Xcode rather than Homebrew; and the unchanged section on building Boost and libevent by hand was not run. The macOS CI job covers the Autotools path on a fresh runner; the CMake path has no CI coverage.

This change was created with AI assistance.

[Jens-G]

Code review

Found 2 issues:

1. The Autotools recipe does not work with the dependencies the page lists. brew install cmake boost libevent openssl bison flex installs none of autoconf, automake, libtool or pkg-config, and macOS does not ship them. The recipe starts with ./bootstrap.sh, which exits with "Couldn't find libtoolize!" when libtool is missing. It also requires automake 1.13 or later and runs aclocal/autoconf/automake, and configure.ac needs the pkg-config macros. The macOS CI job installs automake bison flex boost libevent openssl libtool pkg-config before running the same steps. (bug due to doc/install/os_x.md: brew install cmake boost libevent openssl bison flex, followed by ./bootstrap.sh)

thrift/doc/install/os_x.md

Lines 23 to 25 in 362d954

	```bash
	brew install cmake boost libevent openssl bison flex
	```

thrift/.github/workflows/build.yml

Lines 131 to 133 in 362d954

	run: |
	brew install automake bison flex boost libevent openssl libtool pkg-config
	echo "$(brew --prefix bison)/bin" >> $GITHUB_PATH

2. The commit has no AI attribution trailer, although the PR description says the change was created with AI assistance (AGENTS.md says "Always label AI-assisted commits and PRs. Use one or both of: Co-Authored-By: <AI tool name and version> / Generated-by: <AI tool name and version>").

thrift/AGENTS.md

Lines 60 to 74 in 362d954

	- **Always** label AI-assisted commits and PRs. Use one or both of:
	```
	Co-Authored-By: <AI tool name and version>
	Generated-by: <AI tool name and version>
	```
	Example:
	```
	THRIFT-9999: Fix connection timeout handling in Go client
	Client: go
	Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
	```
	- Apply this label even when AI only generated a portion of the change.
	- **Never** put tool-internal links into a commit message, PR description, JIRA comment or e-mail.

Two suggestions, below the bar for the list above but verified:

• The page is about installing the compiler, but the CMake recipe runs with the default options. Those also build the libraries, tests and tutorials (BUILD_LIBRARIES, BUILD_TESTING and BUILD_TUTORIALS default to ON), and the tests need compiled Boost libraries. The compiler-only options used in doc/ReleaseManagement.md (-DBUILD_TESTING=OFF -DBUILD_TUTORIALS=OFF -DWITH_CPP=OFF … -DBUILD_COMPILER=ON) would match what the page promises. Also, the macOS CI job only runs the Autotools path, so the recipe marked "(Recommended)" is the one that is not tested.

thrift/doc/install/os_x.md

Lines 28 to 37 in 362d954

	#### Building with CMake (Recommended)
	```bash
	cmake -B build \
	-DBISON_EXECUTABLE="$(brew --prefix bison)/bin/bison" \
	-DOPENSSL_ROOT_DIR="$(brew --prefix openssl)"
	cmake --build build
	sudo cmake --install build
	```

• export LDFLAGS="-L$(brew --prefix bison)/lib" is not needed. bison only runs as a program and nothing links against it; CI only adds bison's bin directory to PATH. The export also replaces any LDFLAGS the reader already has set.

thrift/doc/install/os_x.md

Lines 41 to 44 in 362d954

	```bash
	export PATH="$(brew --prefix bison)/bin:$PATH"
	export LDFLAGS="-L$(brew --prefix bison)/lib"

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[Jens-G]

Code review

No blocking issues found. Checked for bugs and CLAUDE.md compliance.

Re-reviewed at 640e71f after the rewrite: the points from the earlier review are addressed.

One suggestion, below the bar for an issue but verified:

• Line 29 says that building the C++ library as well only takes boost libevent openssl and dropping the compiler-only options. On the CMake path that also enables the JavaScript and NodeJS libraries: BUILD_JAVASCRIPT and BUILD_NODEJS default to ON without any check for Node.js, and both add targets to the default build that run npm install. Node.js is not on the page's brew install line, so without it cmake --build cmake-build fails at the first npm install. I reproduced this with these CMake files on Linux, as no Mac was available; the conditions involved do not depend on the platform. Adding -DWITH_JAVASCRIPT=OFF -DWITH_NODEJS=OFF to that variant removes both targets. Java and Python are switched on as well when CMake finds their tools.

thrift/doc/install/os_x.md

Lines 28 to 30 in 640e71f

	The recipes below build only the compiler. To build the C++ library and its tests as well, add `boost libevent openssl` to the `brew install` line and drop the compiler-only options.

thrift/build/cmake/DefineOptions.cmake

Lines 99 to 108 in 640e71f

	# Javascript
	option(WITH_JAVASCRIPT "Build Javascript Thrift library" ON)
	CMAKE_DEPENDENT_OPTION(BUILD_JAVASCRIPT "Build Javascript library" ON
	"BUILD_LIBRARIES;WITH_JAVASCRIPT;NOT WIN32; NOT CYGWIN" OFF)
	# NodeJS
	option(WITH_NODEJS "Build NodeJS Thrift library" ON)
	CMAKE_DEPENDENT_OPTION(BUILD_NODEJS "Build NodeJS library" ON
	"BUILD_LIBRARIES;WITH_NODEJS" OFF)

thrift/lib/nodejs/CMakeLists.txt

Lines 34 to 40 in 640e71f

	add_custom_target(ThriftNodeJS ALL
	COMMENT "Installing NodeJS dependencies with npm"
	COMMAND npm install
	WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/../../"
	)

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[slachiewicz]

Right, dropping BUILD_LIBRARIES=OFF switches on every library CMake finds tools for. 2e838c8 replaces that sentence: the CMake path now names -DWITH_JAVASCRIPT=OFF -DWITH_NODEJS=OFF -DWITH_JAVA=OFF -DWITH_PYTHON=OFF, and the Autotools path --without-<lang> for each other language whose tools are installed.

This comment was created with AI assistance.