Skip to content

ADFA-6548: Rename Addons Manager to Add-ons Manager - #2146

Merged
jimturner-adfa merged 5 commits into
stagefrom
ADFA-6548-rename-to-add-ons-manager
Nov 2, 2026
Merged

jimturner-adfa merged 5 commits into
stagefrom
ADFA-6548-rename-to-add-ons-manager

Conversation

@jimturner-adfa

@jimturner-adfa jimturner-adfa commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

ADFA-6548

Summary

Follow-up to #2048: use the agreed hyphenated spelling, "Add-ons Manager".

  • Preferences entry: "Add-ons Manager" / "Manage IDE extensions".
  • Keys renamed plugin_manager_title -> addons_manager_title and plugin_manager_summary -> addons_manager_summary, in all three locales and pluginPrefExts.kt.
  • title_manager (the manager's top bar) now points to @string/addons_manager_title, so the name is defined once. Side effect: the Indonesian and Chinese title translations now also apply to the top bar, which previously fell back to English. Their text ("Plugin Manager") is unchanged and is out of scope here.
  • Code comments in IDEApplication.kt and ManagerScreen.kt updated to match.

Swept all strings.xml for other "addon" user-facing text: none besides the addons.appdevforall.org URL, left alone.

Testing

  • :app:processV8DebugResources, :app:compileV8DebugKotlin, spotlessCheck and :app:assembleV8Debug pass.
  • On a Pixel 6 Pro (arm64), at font scale 1.0 and 2.0: the Preferences entry and the manager's top bar show the new text with no clipping.
  • Two pre-existing issues seen at 2.0, not caused by this change: the last Preferences rows draw under the navigation bar, and the empty Plugins tab's hint text has no side margin.

🤖 Generated with Claude Code

Use the agreed hyphenated spelling, raised in review of #2048. The
Preferences entry and the manager's top bar now read "Add-ons Manager";
the summary reads "Manage IDE extensions".

Rename plugin_manager_title/summary to addons_manager_title/summary, and
point title_manager at addons_manager_title so the name is defined once.
Side effect: the Indonesian and Chinese translations of the title now also
apply to the manager's top bar, which previously fell back to English.
Their text is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cfc67ca7-8cdd-4f0c-8363-7e75f6816fd0
Commits

Reviewing files that changed from the base of the PR and between 500be46 and 35d0bf1.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 40d2a139-71b8-493a-bac1-98c2cc25f537
Commits

Reviewing files that changed from the base of the PR and between 0f75e61 and 500be46.

Files selected for processing: 1
  • app/src/main/java/com/itsaky/androidide/app/IDEApplication.kt
Files skipped from review as they are similar to previous changes: 1
  • app/src/main/java/com/itsaky/androidide/app/IDEApplication.kt

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Summary
  • Rename the Preferences entry to Add-ons Manager and set its summary to Manage IDE extensions.
  • Rename the title and summary resources in the default, Indonesian, and Simplified Chinese locales. Keep the translated wording unchanged.
  • Set title_manager to @string/addons_manager_title so the manager top bar uses the shared localized title.
  • Update comments to use “Add-ons Manager.”
  • Risks and best practices: The supplied evidence identifies no specific risks or best-practice violations. The author reports two pre-existing layout issues at font scale 2.0: the last Preferences rows extend under the navigation bar, and the empty Plugins tab hint has no side margin.
  • Tests and device checks: The author reports that :app:processV8DebugResources, :app:compileV8DebugKotlin, spotlessCheck, and :app:assembleV8Debug pass. The author also reports no clipping on a Pixel 6 Pro at font scales 1.0 and 2.0.

The changes standardize Add-ons Manager wording in comments, UI documentation, and string resources. The preferences entry now uses renamed resource identifiers. Indonesian and Simplified Chinese display text is unchanged.

Changes: Add-ons Manager terminology

Layer / File(s) Summary
Manager labels and references
resources/src/main/res/values/strings.xml, resources/src/main/res/values-in-rID/strings.xml, resources/src/main/res/values-zh-rCN/strings.xml, app/src/main/java/com/itsaky/androidide/preferences/pluginPrefExts.kt, app/src/main/java/com/itsaky/androidide/ui/compose/ManagerScreen.kt, app/src/main/java/com/itsaky/androidide/app/IDEApplication.kt
Renames manager title and summary resources and updates their preference references. English labels use “Add-ons Manager” and “Manage IDE extensions.” Indonesian and Simplified Chinese display text remains unchanged. Related comments and screen documentation use hyphenated add-ons terminology.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: Minimal · previous review 500be

The reviewed comment-only change is mergeable after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: renaming “Addons Manager” to “Add-ons Manager.”
Description check Passed The description directly explains the spelling update, resource-key renames, affected files, shared title resource, and validation results.
Docstring Coverage Passed Docstring coverage is inconclusive: files from earlier reviews still need to be rechecked within the check's analysis limits. Not blocking.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit reads the labels with care,
“Add-ons Manager” now appears there.
Strings point to names made new,
While translated words stay true.
I hop along, content with the view.

@jimturner-adfa
jimturner-adfa removed the request for review from Elissa-AppDevforAll November 2, 2026 17:09
@jimturner-adfa
jimturner-adfa merged commit fe02be1 into stage Nov 2, 2026
6 checks passed
@jimturner-adfa
jimturner-adfa deleted the ADFA-6548-rename-to-add-ons-manager branch November 2, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants