Skip to content

ADFA-6712: Say a full build is starting instead of asking for a tap #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Daniel-ADFA merged 2 commits into from
Nov 4, 2026
Merged

ADFA-6712: Say a full build is starting instead of asking for a tap #2188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5974bac
ADFA-6712: Say a full build is starting instead of asking for a tap
Daniel-ADFA Oct 26, 2026
783fa7e
Merge branch 'stage' into bugfix/ADFA-6712-quick-build-status-text
Daniel-ADFA Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions app/src/main/java/com/itsaky/androidide/quickbuild/QuickBuildOutputLines.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,7 @@ fun quickBuildOutputLines(
// of narrating upcoming work.
listOf("the rebuild failed - save a fix to retry.")
} else {
listOf(
"a full build is needed - ${describe(transition.reason)}. " +
"Tap Quick Build to rebuild.",
)
listOf("a full build is needed - ${describe(transition.reason)}. Starting it now.")
Comment thread
Daniel-ADFA marked this conversation as resolved.
Resolved
Comment thread
Daniel-ADFA marked this conversation as resolved.
Resolved
}
}

Expand Down
5 changes: 3 additions & 2 deletions app/src/test/java/com/itsaky/androidide/quickbuild/QuickBuildOutputLinesTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,15 +251,16 @@ class QuickBuildOutputLinesTest {
}

@Test
fun `invalidation reads as information and names a next step`() {
fun `invalidation reads as information and says the full build is starting`() {
val emitted =
lines(
QuickBuildStatus.UpToDate(4L, buildDurationMillis = null),
QuickBuildStatus.NeedsFullBuild(InvalidationReason.MANIFEST_CHANGED, 4L),
).joinToString("")

assertThat(emitted).contains("the manifest changed")
assertThat(emitted).contains("Tap Quick Build")
assertThat(emitted).contains("Starting it now")
assertThat(emitted).doesNotContain("Tap")
// Not a failure - a full build is the normal answer to an unabsorbable edit.
assertThat(emitted).doesNotContain("failed")
}
Expand Down
2 changes: 1 addition & 1 deletion app/src/test/java/com/itsaky/androidide/quickbuild/QuickBuildStatusBarTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ class QuickBuildStatusBarTest {
}

@Test
fun `an invalidation names the full-build ask`() {
fun `an invalidation says the full build is starting`() {
val shown =
update(
QuickBuildStatus.UpToDate(4L, null),
Expand Down
2 changes: 1 addition & 1 deletion resources/src/main/res/values-pt-rBR/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,7 +1061,7 @@
<string name="quick_build_status_failed">A Compilação rápida falhou; veja a Saída da compilação</string>
<string name="quick_build_status_deploy_failed">Compilação rápida: falha na entrega; veja a Saída da compilação</string>
<string name="quick_build_status_app_not_running">Compilação rápida: compilado; toque para iniciar o aplicativo</string>
<string name="quick_build_status_needs_full_build">Compilação rápida: toque novamente para recompilar</string>
<string name="quick_build_status_needs_full_build">Compilação rápida: iniciando uma compilação completa…</string>
<string name="quick_build_status_rebuild_failed">A Compilação rápida falhou; veja a Saída da compilação</string>
<string name="quick_build_status_start_failed">Compilação rápida: falha na configuração; toque para tentar novamente</string>
<string name="quick_build_flash_failed">A Compilação rápida falhou. Consulte o painel Saída da compilação para mais detalhes.</string>
Expand Down
2 changes: 1 addition & 1 deletion resources/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,7 +1215,7 @@
<string name="quick_build_status_failed">Quick Build failed - see Build Output</string>
<string name="quick_build_status_deploy_failed">Quick Build: delivery failed - see Build Output</string>
<string name="quick_build_status_app_not_running">Quick Build: built - tap to start app</string>
<string name="quick_build_status_needs_full_build">Quick Build: tap again to rebuild</string>
<string name="quick_build_status_needs_full_build">Quick Build: starting a full build…</string>
<string name="quick_build_status_rebuild_failed">Quick Build failed - see Build Output</string>
<string name="quick_build_status_start_failed">Quick Build: setup failed - tap to retry</string>
<string name="quick_build_flash_failed">Quick Build failed. See the Build Output panel for more details.</string>
Expand Down
Loading