Repository navigation
K2GO-456 chore(cleanup): remove unused biometric code, library and permissions - #643
Merged
Merged
Conversation
…rmissions BiometricHelper had no callers, but the androidx.biometric library injected USE_BIOMETRIC and USE_FINGERPRINT into the merged manifest: biometric permissions the app never uses. Delete the helper, drop the library (which removes both permissions), remove the orphaned security_required_* strings, and clear the stale biometric mentions in TerminalController.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BiometricHelper had no callers, but the androidx.biometric library injected
USE_BIOMETRIC and USE_FINGERPRINT into the merged manifest: the APK declared
biometric permissions the app never uses (Play counts declared permissions, not
runtime use).
Changes:
(all locales). Keep go_to_settings (shared with BatteryUtils).
Verification: assembleStandardDebug green; the packaged manifest no longer
declares either permission.