Repository navigation
K2GO-376 fix(conex-core): log failures to stdout, run unbuffered - #725
Merged
Merged
Conversation
conex-core.log stayed empty because the server ran python3 without -u: block-buffered stdout never flushed while serve_forever runs, and the only output was a startup print, so a failed import left no trace. Add a logger that records every error response (path logged without its query, so a ?token=... never lands in the log) and every uncaught handler exception; an uncaught error now returns a 500 JSON instead of dropping the connection. Run the server unbuffered (-u) in both supervisors (PDSM wrapper + systemd). conex-core 0.3.3 (+CHANGELOG).
…per-supervisor -u Line-buffer stdout/stderr in __main__ instead of passing -u in each supervisor, so the flush guarantee is one fact in one place and holds however the core is launched (a third supervisor would otherwise repeat -u). No behavior change: the error log still populates.
Collaborator
Author
|
Update (fc53c15): the flush guarantee moved into the core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
python3 -u(PDSM wrapper and systemd unit).Why
/var/log/conex-core.logstayed empty: stdout was block-buffered and never flushed, so a failed import left no trace on the box.Verifications
conex-core.lognow records startup and error responses.Notes