Repository navigation
chore(deps): bump node-appwrite from 11.1.1 to 31.0.0 in /bun/sync-with-meilisearch - #381
dependabot[bot] wants to merge 1 commit into
Conversation
🟡 Tier B · Needs changes before merging
The sync-with-Meilisearch template upgrades node-appwrite from the 11.x line to 31.0.0. The Bun lockfile is updated to match the new SDK and its dependency graph.
Note Not approving while a bug finding is open: Handle BigInt values before indexing documents Fix with agent prompt### Issue 1
bun/sync-with-meilisearch/package.json:12
**Handle BigInt values before indexing documents**
This SDK version returns integer fields above 2^53 as `BigInt`, but this function passes `documents` directly to `index.addDocuments`, whose JSON serialization throws on a `BigInt`. Syncs now fail when a collection contains such a value; the Node counterpart converts `BigInt` values to strings before indexing.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 2
⏳ Still open from earlier reviews · 1
Reviewed |
| "dependencies": { | ||
| "meilisearch": "^0.35.0", | ||
| "node-appwrite": "^11.0.0" | ||
| "node-appwrite": "^30.0.0" |
There was a problem hiding this comment.
Handle BigInt values before indexing documents
This SDK version returns integer fields above 2^53 as BigInt, but this function passes documents directly to index.addDocuments, whose JSON serialization throws on a BigInt. Syncs now fail when a collection contains such a value; the Node counterpart converts BigInt values to strings before indexing.
Prompt To Fix With AI
This is a comment left during a code review.
Path: bun/sync-with-meilisearch/package.json
Line: 12
Comment:
**Handle BigInt values before indexing documents**
This SDK version returns integer fields above 2^53 as `BigInt`, but this function passes `documents` directly to `index.addDocuments`, whose JSON serialization throws on a `BigInt`. Syncs now fail when a collection contains such a value; the Node counterpart converts `BigInt` values to strings before indexing.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · bug · Reply if this doesn't apply.
Bumps [node-appwrite](https://github.com/appwrite/sdk-for-node) from 11.1.1 to 31.0.0. - [Release notes](https://github.com/appwrite/sdk-for-node/releases) - [Changelog](https://github.com/appwrite/sdk-for-node/blob/main/CHANGELOG.md) - [Commits](appwrite/sdk-for-node@11.1.1...31.0.0) --- updated-dependencies: - dependency-name: node-appwrite dependency-version: 30.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7bcdb7e to
e840a6b
Compare
Bumps node-appwrite from 11.1.1 to 31.0.0.
Release notes
Sourced from node-appwrite's releases.
... (truncated)
Changelog
Sourced from node-appwrite's changelog.
... (truncated)
Commits
3725f1cfeat: SDK update for version 31.0.0 (#179)13dbe4aMerge pull request #178 from appwrite/devf646a57docs: refresh README3ffbdebMerge commit 'a8e771af9014c509e9f802c7320451e7fa0936e6' into dev320249dMerge pull request #177 from appwrite/deva8e771afeat: SDK update for the 2.5.x majors47f77d1Merge remote-tracking branch 'origin/dev' into dev6a35b33feat: SDK update for the 2.5.x majors698ec7eMerge remote-tracking branch 'origin/dev' into dev013085cfeat: SDK update for the 2.5.x majorsMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for node-appwrite since your current version.