Repository navigation
chore(deps): bump node-appwrite from 11.1.1 to 31.0.0 in /bun/sync-with-qdrant - #382
dependabot[bot] wants to merge 1 commit into
Conversation
🔵 Tier A · Mergeable after minor fixes
This updates the Bun sync-with-Qdrant template from node-appwrite 11 to 31 and refreshes its lockfile for the SDK's new dependencies. The manifest and lockfile now both specify the ^31.0.0 version range.
Note Not approving while a bug finding is open: node-appwrite 31 requires Node 20
Fix with agent prompt### Issue 1
bun/sync-with-qdrant/bun.lock:129
**node-appwrite 31 requires Node 20**
This SDK version declares `engines.node >=20.0.0`, but this template documents Node 18 as its runtime in `bun/sync-with-qdrant/README.md`. Deployments following that runtime configuration will run the SDK outside its supported engine range; please align the runtime or use an SDK version that supports Node 18.
### Issue 2
bun/sync-with-qdrant/package.json:12
**Handle BigInt values returned by the upgraded SDK**
The newer SDK parses database integers outside JavaScript's safe range as `BigInt`, but this template passes fetched documents to `JSON.stringify` in `src/main.ts` (and then to Qdrant) without normalizing them. A collection containing such a value will throw during sync and never reach the upsert; the Node Qdrant counterpart already converts these values before serialization.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 2
⏳ Still open from earlier reviews · 1
Reviewed |
| "dependencies": { | ||
| "@qdrant/js-client-rest": "^1.9.0", | ||
| "node-appwrite": "^11.0.0", | ||
| "node-appwrite": "^30.0.0", |
There was a problem hiding this comment.
Handle BigInt values returned by the upgraded SDK
The newer SDK parses database integers outside JavaScript's safe range as BigInt, but this template passes fetched documents to JSON.stringify in src/main.ts (and then to Qdrant) without normalizing them. A collection containing such a value will throw during sync and never reach the upsert; the Node Qdrant counterpart already converts these values before serialization.
Prompt To Fix With AI
This is a comment left during a code review.
Path: bun/sync-with-qdrant/package.json
Line: 12
Comment:
**Handle BigInt values returned by the upgraded SDK**
The newer SDK parses database integers outside JavaScript's safe range as `BigInt`, but this template passes fetched documents to `JSON.stringify` in `src/main.ts` (and then to Qdrant) without normalizing them. A collection containing such a value will throw during sync and never reach the upsert; the Node Qdrant counterpart already converts these values before serialization.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · bug · Reply if this doesn't apply.
Bumps [node-appwrite](https://github.com/appwrite/sdk-for-node) from 11.1.1 to 31.0.0. - [Release notes](https://github.com/appwrite/sdk-for-node/releases) - [Changelog](https://github.com/appwrite/sdk-for-node/blob/main/CHANGELOG.md) - [Commits](appwrite/sdk-for-node@11.1.1...31.0.0) --- updated-dependencies: - dependency-name: node-appwrite dependency-version: 30.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
3781af1 to
341f20f
Compare
| "ms": ["ms@2.1.3", "", {}, "sha512-6FlzubTLZG3J2a/NVCAleEhjzq5oxgHyaCU9yYXvcLsvoVaHJq/s5xXI6/XXP6tz7R9xAOtHnSO/tXtF3WRTlA=="], | ||
|
|
||
| "node-appwrite": ["node-appwrite@11.1.1", "", { "dependencies": { "axios": "^1.4.0", "form-data": "^4.0.0" } }, "sha512-j9QTHfsDx/RoLq9shVtpDWofCG8u/izy6uQrlzet7+UV14OMikaPUNZpQhtZGi5KjLy5R+JvJfx6HHXrfdcIvQ=="], | ||
| "node-appwrite": ["node-appwrite@31.0.0", "", { "dependencies": { "json-bigint": "1.0.0", "undici": "^6.27.0" } }, "sha512-HSt6iPkY0eXABlFvtDgsDDuQwEZqRWyVD5F0/VDnVEp8WxVOXrM4WdcOB56xosxvpPUMg94qUcns7c9qf21+7w=="], |
There was a problem hiding this comment.
node-appwrite 31 requires Node 20
This SDK version declares engines.node >=20.0.0, but this template documents Node 18 as its runtime in bun/sync-with-qdrant/README.md. Deployments following that runtime configuration will run the SDK outside its supported engine range; please align the runtime or use an SDK version that supports Node 18.
Prompt To Fix With AI
This is a comment left during a code review.
Path: bun/sync-with-qdrant/bun.lock
Line: 129
Comment:
**node-appwrite 31 requires Node 20**
This SDK version declares `engines.node >=20.0.0`, but this template documents Node 18 as its runtime in `bun/sync-with-qdrant/README.md`. Deployments following that runtime configuration will run the SDK outside its supported engine range; please align the runtime or use an SDK version that supports Node 18.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · bug · Reply if this doesn't apply.
Bumps node-appwrite from 11.1.1 to 31.0.0.
Release notes
Sourced from node-appwrite's releases.
... (truncated)
Changelog
Sourced from node-appwrite's changelog.
... (truncated)
Commits
3725f1cfeat: SDK update for version 31.0.0 (#179)13dbe4aMerge pull request #178 from appwrite/devf646a57docs: refresh README3ffbdebMerge commit 'a8e771af9014c509e9f802c7320451e7fa0936e6' into dev320249dMerge pull request #177 from appwrite/deva8e771afeat: SDK update for the 2.5.x majors47f77d1Merge remote-tracking branch 'origin/dev' into dev6a35b33feat: SDK update for the 2.5.x majors698ec7eMerge remote-tracking branch 'origin/dev' into dev013085cfeat: SDK update for the 2.5.x majorsMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for node-appwrite since your current version.