Skip to content

chore(tools): bump Docker toolchain to latest stable versions - #763

Open
arcbox-labs[bot] wants to merge 1 commit into
masterfrom
chore/bump-toolchain
Open

arcbox-labs[bot] wants to merge 1 commit into
masterfrom
chore/bump-toolchain

Conversation

@arcbox-labs

@arcbox-labs arcbox-labs Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • docker: 29.9.2 -> 29.9.3
  • docker-buildx: 0.38.1 -> 0.39.0
  • docker-compose: 5.6.1 -> 5.7.1
  • docker-credential-osxkeychain: 0.9.12 -> 0.9.13
  • kubectl: 1.37.1 -> 1.37.2

Checksums verified by downloading binaries and computing SHA-256.

Before merging a docker bump: check it against the guest dockerd in the boot bundle [boot] pins (upstream.toml at that tag in the boot-assets repo). See the header of assets.lock — the two are meant to diverge only between a bundle release and the [boot] bump. buildx and compose have no guest-side twin.

Auto-generated by cargo xtask release check-tool-updates.

pullfrog[bot]
pullfrog Bot previously approved these changes Nov 2, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes
Auto-generated toolchain-bump PR (cargo xtask release check-tool-updates); reviewed the lockfile diff and independently re-verified the pin against the same sources the generator uses.

  • kubectl 1.37.1 → 1.37.2 — the kubernetes-group entry in assets.lock only: version plus the two darwin SHA-256 pins. Nothing else in the file moved and the [boot] bundle pins are untouched.

Verification:

  • https://dl.k8s.io/release/stable.txt reports v1.37.2, so the pin is current.
  • Downloaded both darwin artifacts from the pinned URL templates (dl.k8s.io/release/v1.37.2/bin/darwin/{arm64,amd64}/kubectl) and recomputed SHA-256: both match the recorded values (55701af0… arm64, 88379aff… x86_64).
  • No stale 1.37.1 pins elsewhere in the repo; the two grep hits are an unrelated ArcBox Dev app version in docs/logs/2026-10-09-https-validation-preparation.md.

Two boilerplate notes, neither an issue with this change: the body's "check against the guest dockerd" warning only ever applies to the docker tool (assets.lock header) — kubectl is kubernetes-group with no guest-side twin, so no boot-bundle coupling applies here; and the "Docker toolchain" title is hardcoded generator copy (.github/workflows/check-tool-updates.yml lines 66 and 85), which is why a kubectl-only bump carries it.

Pullfrog  | View workflow run | Using glm-5.3-flash | 𝕏

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The docker hunk diverges from the guest dockerd pinned in the boot bundle — hold it (or land it combined with a [boot] bump). The buildx, compose, and kubectl hunks verified clean.

Reviewed changes

Incremental review of the new commits since the prior pullfrog review (which covered the kubectl bump only): the branch now also bumps the three docker-group tools in assets.lock.

  • Bumped docker 29.9.2 → 29.9.3, docker-buildx 0.38.1 → 0.38.2 and docker-compose 5.6.1 → 5.7.0, each with fresh darwin sha256 pins. All six checksums match re-downloaded artifacts from the same URL templates the runtime uses, and all three versions are still the upstream latest (moby/moby, docker/buildx, docker/compose latest-release redirects).
  • Re-checked the guest-dockerd coupling the PR body warns about: the pinned boot bundle v0.8.12 (manifest hash matches the [boot] pin, and it is the newest boot-assets release) ships dockerd 29.9.2 — that makes the docker hunk the one finding, inline below.
  • kubectl 1.37.2 unchanged since the prior review; old-version sweep outside assets.lock is clean (only the guest-package text in docs/boot-assets.md, which legitimately tracks [boot]).

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using glm-5.3-flash | 𝕏

Comment thread assets.lock
version = "29.9.2"
arch.arm64.sha256 = "ea8a2ce5ac31f9f5f3fb711a7a485e1e46cc7a69798a629a70306f6e6af25b7a"
arch.x86_64.sha256 = "089c3f618df88bdef4f1257d9d604499136a1ec5168b67d194c260acad2b522f"
version = "29.9.3"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bump diverges the host docker CLI (29.9.3) from the guest dockerd in the pinned boot bundle, which is still 29.9.2, with no [boot] bump in this PR to bound the gap. Per the assets.lock header the two pins should only diverge for the short window between a bundle release and the [boot] bump, and a generated PR whose docker hunk would diverge gets that hunk stripped, landing later as a combined [[tools]] + [boot] commit. No runtime breakage (the CLI tolerates an older daemon via API negotiation) — this is the release invariant, not a functional bug.

Technical details
# Hold the `docker` hunk until the boot bundle catches up (or land it combined with `[boot]`)

## Affected sites
- assets.lock:38-40 — `docker` `[[tools]]` bumped to 29.9.3 while the pinned boot bundle's guest dockerd stays 29.9.2.

## Evidence
- `[boot]` pins bundle `v0.8.12`; `https://boot.arcboxcdn.com/asset/v0.8.12/manifest.json` hashes to the recorded `manifest_sha256` (`4e1638ce…`), so the pin is live.
- That manifest's `binaries[]` report `dockerd`/`containerd`/`runc` = `29.9.2`.
- `https://api.github.com/repos/arcboxlabs/boot-assets/releases` lists `v0.8.12` (2026-10-31) as the newest bundle — no release shipping dockerd 29.9.3 exists yet.
- Host side is otherwise clean: all six new sha256 pins match re-downloaded artifacts from the `registry.rs::download_url` templates, and `moby/moby` / `docker/buildx` / `docker/compose` latest-release redirects confirm 29.9.3 / 0.38.2 / 5.7.0 are still current. `docker-buildx`, `docker-compose`, and `kubectl` have no guest twin and can merge freely.

## Required outcome
- The `docker` hunk must not merge ahead of a guest dockerd 29.9.3: either strip it from this PR (the other three hunks merge now), or hold the whole PR until a boot-assets bundle ships dockerd 29.9.3 and land `[boot] version` + `manifest_sha256` in the same PR as the `[[tools]]` bump.

## Notes
- The upstream `upstream.toml` for the bundle tag lives in the boot-assets repo; this PR's body links the procedure.

@arcbox-labs
arcbox-labs Bot force-pushed the chore/bump-toolchain branch from fcfc583 to 3a3e969 Compare November 16, 2026 09:14

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The delta since the last review verifies clean, but the previously flagged hold still applies: the force-push re-applied the docker 29.9.3 hunk while the pinned boot bundle still ships guest dockerd 29.9.2 (v0.8.12 remains the newest boot-assets release, re-confirmed today). Strip the docker hunk from this PR — the other four hunks merge now — or hold until a bundle ships dockerd 29.9.3 and land [boot] + [[tools]] together. The open review thread tracks this.

Reviewed changes

Incremental review of the delta since the prior pullfrog review (fcfc583 → 3a3e969d, generator force-push): two pins moved forward and a new tool hunk joined the PR.

  • Re-bumped docker-buildx and docker-compose — now 0.38.1 → 0.39.0 and 5.6.1 → 5.7.1, superseding the 0.38.2 / 5.7.0 pins of the previous head.
  • Added a docker-credential-osxkeychain hunk — 0.9.12 → 0.9.13, not present in the previous head.
  • docker and kubectl hunks unchanged from the prior head (29.9.3 and 1.37.2 respectively).

Verification (downloads and latest checks use the same URL templates and endpoints the generator and runtime use):

  • All six new sha256 pins for buildx 0.39.0, compose 5.7.1 and osxkeychain 0.9.13 match re-downloaded artifacts (Binary-format checksums).
  • /releases/latest still reports v0.39.0 / v5.7.1 / v0.9.13 / docker-v29.9.3 — every bumped version is upstream current.
  • Old-version sweep outside assets.lock is clean; the 0.9.12 hits are the unrelated parking_lot_core crate (Cargo.lock, NOTICE.md).
  • Guest-dockerd coupling re-checked today: latest.json says 0.8.12, the boot-assets releases API still lists v0.8.12 (2026-10-31) as newest, and its manifest reports dockerd/containerd/runc = 29.9.2 — the docker hunk still diverges; tracked in the open review thread, not re-raised inline.

Pullfrog  | Fix it ➔ | View workflow run | Using glm-5.3-flash | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants