Repository navigation
Conversation
Allows for easily running an archweb development locally with a single command.
jelly
left a comment
jelly
left a comment
There was a problem hiding this comment.
I'm a bit on the fence but I suppose folks like to use containerized workflows so why not, but lets keep it vendor neutral.
| *.db | ||
| collected_static | ||
| htmlcov | ||
| **/__pycache__ |
There was a problem hiding this comment.
This is sadly not vendor neutral, there is containerignore but ofcourse docker does not support that....
| COPY pyproject.toml uv.lock ./ | ||
| RUN uv sync --frozen --no-install-project | ||
|
|
||
| COPY . . |
There was a problem hiding this comment.
So I suppose this is why you neeed the .dockerignore? As you copy the whole working directory over?
|
|
||
| # Testing Installation | ||
|
|
||
| ## Docker (recommended) |
There was a problem hiding this comment.
Why is this recommended? I would like to use Podman instead for example.
| @@ -0,0 +1,26 @@ | |||
| FROM archlinux:latest | |||
There was a problem hiding this comment.
This should be a Containerfile, which both podman/docker should support.
| See step 8 of the local installation below for customization notes. | ||
|
|
||
| All data is stored inside the container and is lost when the container is | ||
| removed. |
There was a problem hiding this comment.
Maybe it is useful to keep the DB around or allow bind mounting it?
I think it's very useful to have some way of running the whole project with as few steps as possible and as little "pollution" as possible to make it more likely for one-time contributors to submit small fixes/improvements. I don't think the exact technology matters too much, as long as it's somewhat widespread and achieves the goals of being quick and isolated. @jelly - Before I address the other comments, let me know if you agree/disagree with this in general -- I think having this would benefit the project but I'm happy to keep the setup locally instead. |
I didn't say I was against it, it should however not be docker specific if it can be. |
Allows for easily running an archweb development locally with a single command.