Repository navigation
Conversation
Prior to this commit, misspelled or incorrect package names are silently dropped. Show a warning below the todo list description.
Each todo list gets a fixed set of stages chosen at creation time, defaulting to Draft, Rebuild in staging and Test in testing for rebuilds and Draft and In progress for tasks. The list proceeds through its stages manually; stages asking for per-package completion can only be left once all packages are marked as complete. Package maintainers are notified when the list reaches a stage asking for per-package completion, the creator once all packages completed it. The per-package status is replaced by a progress counter. Existing lists are migrated to a single In progress stage.
Rebuilds touching the same package bases interfere with each other in the staging and testing repositories. Show a warning on an active rebuild for every other active rebuild sharing package bases with it.
Users without a profile, e.g. created using createsuperuser, have no time zone set, which made rendering the "Last Touched By" column fail as soon as a package had been touched. Fall back to UTC in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes several improvements to todo lists. New features:
With these changes, it's possible to just queue new rebuilds as drafts, and then consolidate and coordinate early, based on warnings and issues detected -- reducing guesswork and communication overhead w/o having a shared, structured, consolidated overview. They should also make the process of safely moving rebuilds between repos easier.
Going through a normal rebuild now requires three extra clicks: one click to make a draft an active rebuild, one click to mark a rebuild as moved to the testing repos, and one click to eventually close the rebuild.
Screenshot of a rebuild in draft mode that overlaps with an ongoing rebuild:
Screenshot of an ongoing rebuild that overlaps with the draft rebuild:
Screenshot of a rebuild that's been moved to testing and contains an invalid package name:
New todo list overview:
