[MINOR BC] [4.x] Make storage features not depend on the suffix_storage_path config - #1479

Merged

stancl merged 71 commits into

suffix-storage-path

Sep 21, 2026

Commits on Sep 8, 2026

Make DeleteTenantStorage test assert the expected behavior

lukinovec
authored and
stancl
committed
3cc7902
Make DeleteTenantStorage delete the tenant storage directory regardless of suffix_storage_path

lukinovec
authored and
stancl
committed
0bd5852
Make storage symlink test assert the expected behavior

lukinovec
authored and
stancl
committed
179114b
Make storage symlinks point to the tenant's disk root instead of storage_path()

lukinovec
authored and
stancl
committed
98d8647
Assert that TenantAssetController does not depend on storage_path() suffixing (regression test)

lukinovec
authored and
stancl
committed
a9a7274
Make TenantAssetController not depend on suffixed storage_path()

lukinovec
authored and
stancl
committed
11fec03
Make the disk used for serving tenant assets configurable

lukinovec
authored and
stancl
committed
b771fd1
Restore the central storage directory check in DeleteTenantStorage

lukinovec
authored and
stancl
committed
1fb9ace
Assert that DeleteTenantStorage does not delete the central storage directory when the FS bootstrapper is disabled

lukinovec
authored and
stancl
committed
c1e09fb
Fix the suffix_storage_path comment in the config

lukinovec
authored and
stancl
committed
a9cdeb2
Assert that the tenant asset controller only serves files inside the configured disk's root (regression test)

lukinovec
authored and
stancl
committed
ff3a2a3
Require a directory boundary when checking that an asset is inside the asset root

lukinovec
authored and
stancl
committed
4e1fb85
Assert that CreateStorageSymlinksAction cannot create symlinks for disks that are not in tenancy.filesystem.disks, i.e. aren't tenant-aware (regression test)

lukinovec
authored and
stancl
committed
b6e6aa6
Throw an exception in possibleTenantSymlinks if the disk is not tenant-aware

lukinovec
authored and
stancl
committed
0eb2cf1
Correct the regression test

lukinovec
authored and
stancl
committed
2bd590e
Make the suffix_storage_path config comment clearer

lukinovec
authored and
stancl
committed
79484ca
Assert that symlinks work without a root_override and that disks with a null url_override are skipped (regression test)

lukinovec
authored and
stancl
committed
aad435d
Stop requiring a root_override in possibleTenantSymlinks

lukinovec
authored and
stancl
committed
ae77c49
Correct FSBootstrapper and DeleteTenantStorage docblocks

lukinovec
authored and
stancl
committed
223b49a
Assert that disks with an empty url_override are skipped by both the FS bootstrapper and possibleTenantSymlinks (regression test)

lukinovec
authored and
stancl
committed
6b27bc5
Skip disks with *empty* url_override in diskUrl()

lukinovec
authored and
stancl
committed
7ecb34f
Update tenancy.filesystem config docblocks

lukinovec
authored and
stancl
committed
15144de
Improve comments

lukinovec
authored and
stancl
committed
1a693d8
Add test that covers how tenant_asset() works when called in central context

lukinovec
authored and
stancl
committed
4826667
Reword DeleteTenantStorage docblock

lukinovec
authored and
stancl
committed
5e54e3e
Add afterEach cleanup to TenantAssetTest

lukinovec
authored and
stancl
committed
9403d8c
Clarify TenantAssetController docblock

lukinovec
authored and
stancl
committed
8487364
Assert that the tenant asset root is read from the resolved disk (regression tests)

lukinovec
authored and
stancl
committed
efa8c03
Read the tenant asset root from the resolved disk instead of the disk config

lukinovec
authored and
stancl
committed
e70057e
Exercise the valid asset path before testing traversal

lukinovec
authored and
stancl
committed
802022a
Fix code style (php-cs-fixer)

github-actions[bot]
authored and
stancl
committed
ae98ac3
Clarify TenantAssetController's docblock

lukinovec
authored and
stancl
committed
ae88836
Make LogChannelBootstrapper not depend on suffixed storage_path()

lukinovec
authored and
stancl
committed
2ef1ea9
Update src/Jobs/DeleteTenantStorage.php

lukinovec
and
stancl
committed
bb12443
improve comments
stancl
committed
41f7e2e
Use "placed within" instead of "appended to" in log bootstrapper comment

lukinovec
authored and
stancl
committed
8e671fe
Delete redundant comment

lukinovec
authored and
stancl
committed
99994dc
Assert that TenantAssetController cannot serve assets from a disk that isn't tenant-aware (regression test)

lukinovec
authored and
stancl
committed
041b023
Throw an exception in TenantAssetController if the disk is not tenant-aware

lukinovec
authored and
stancl
committed
e0e696f
Assert that nested scoped disks are scoped properly (regression test)

lukinovec
authored and
stancl
committed
ae91281
Test that non-local scoped disks get scoped per tenant

lukinovec
authored and
stancl
committed
3936ab9
Test that listing scoped disks in tenancy.filesystem.disks is harmless (regression test)

lukinovec
authored and
stancl
committed
2cd514c
Assert that TenantAssetController throws for scoped disks with a non-local parent

lukinovec
authored and
stancl
committed
e200855
Forget scoped disk's parent no matter how nested it is

lukinovec
authored and
stancl
committed
9cda4cb
Explicitly skip scoped disks in diskRoot()

lukinovec
authored and
stancl
committed
394a9fa
minor polish
stancl
committed
efc0877
Add comment above $attemptedPath

lukinovec
authored and
stancl
committed
e7c0193
Throw an exception if a scoped disk is listed in tenant-aware disks without its base disk

lukinovec
authored and
stancl
committed
dde9be6
Simplify baseDiskName()

lukinovec
authored and
stancl
committed
197ca18
Fix getBoundTenantStoragePath -> getTenantStoragePath rename leftover

lukinovec
authored and
stancl
committed
45f6bc6
Improve TenantAssetController comments
lukinovec
committed
496e0c3
Refactor scoped disks test
lukinovec
committed
4510045
Refactor DeleteTenantStorage tests
lukinovec
committed
e6d785a
Refactor scoped disk exception throwing tests, remove redundant test
lukinovec
committed
e3ba445
Move falsy url_override assertions to more appropriate places
lukinovec
committed
4af473e
Merge the new "throws an exception when accessing a file in a directory whose name starts with the name of the asset root" test with the pre-existing one
lukinovec
committed
1abeb85
Merge 'not a local disk'/'not tenant-aware'/'unnamed parent' throwing tests into a single test
lukinovec
committed
fe85fe4
Merge the 'served from the resolved root' tests
lukinovec
committed
823e5c3
Delete the 'tenant assets are served from the central storage path in central context' test
lukinovec
committed
9bfc9c4

Commits on Sep 9, 2026

add assertion to ensure the two paths are the same
stancl
committed
d783879
minor test cleanup
stancl
committed
9673464
Add symlink support for prefixed disks
lukinovec
committed
b2b8d50

Commits on Sep 10, 2026

Refactor remove symlinks action, add static::$removeNestedDirectories
lukinovec
committed
1e1e2ef
Improve symlink comments
lukinovec
committed
9e890e9

Commits on Sep 11, 2026

rtrim directory and public root in remove symlinks action
lukinovec
committed
9ec732c
Update removeNestedDirectories docblock
lukinovec
committed
42df25a

Commits on Sep 14, 2026

In the asset controller, throw if tenancy isn't initialized
lukinovec
committed
1a3ab47
Assert symlink jobs dispatch events
lukinovec
committed
388f253

Commits on Sep 15, 2026

Use rmdir instead of deleteDirectory
lukinovec
committed
35d96b5

Commits on Sep 18, 2026

remove directory rtrim
lukinovec
committed
1ef7710

Commits on Sep 21, 2026

0777 -> 0750, ignore mkdir errors (see past commits fixing TOCTOU)
stancl
committed
77f374b