Repository navigation
Props not being extracted when using both memo and forward ref #201
Description
Doesn't work:
import { TextfieldProps } from './types';
const Textfield = forwardRef((props: TextfieldProps, ref) => {
^^^^^^^^^^^^^^^ not extracted
return <input />;
});
Textfield.displayName = 'Textfield';
export default memo(Textfield);Doesn't work:
import { TextfieldProps } from './types';
const Textfield = forwardRef<unknown, TextfieldProps>((props: TextfieldProps, ref) => {
^^^^^^^^^^^^^^^ not extracted
return <input />;
});
Textfield.displayName = 'Textfield';
export default memo(Textfield);Works
import { TextfieldProps } from './types';
const Textfield = forwardRef((props: TextfieldProps, ref) => {
return <input />;
});
Textfield.displayName = 'Textfield';
export default memo<TextfieldProps>(Textfield);
^^^^^^^^^^^^^^^ extracts, but now missing ref prop in the component types
Activity
danieldelcore commentedon Jul 26, 2021
Yeah that's a bit of a weird one.
I think case one and two both work without the
memo. We'll need to add some additional smarts to get it to work with it though.This should work if you wrap a typed
forwardRefin an untypedmemo. Not ideal, just sharing incase you were blocked 😄(https://github.com/atlassian/extract-react-types/blob/master/packages/extract-react-types/converters-typescript.test.js#L656)