Skip to content

chore(samples): v1.x housekeeping (lint scope, webpack dev server, npm audit fix) #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imdt-claudiop wants to merge 5 commits into
base: v1.x
Choose a base branch
from
Open

chore(samples): v1.x housekeeping (lint scope, webpack dev server, npm audit fix) #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ea540c
chore(samples): lint src recursively and drop build:watch
imdt-claudiop Oct 5, 2026
5c608eb
chore(samples): drop the unused eslint-watch and lint-staged
imdt-claudiop Oct 6, 2026
25950a2
chore(samples): serve the manifest from setupMiddlewares
imdt-claudiop Oct 6, 2026
41c7356
chore(samples): allow require() in webpack.config.js under @typescrip…
imdt-claudiop Oct 6, 2026
91297a3
chore(samples): npm audit fix
imdt-claudiop Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4,281 changes: 2,586 additions & 1,695 deletions samples/sample-actions-bar-plugin/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions samples/sample-actions-bar-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"scripts": {
"build-bundle": "webpack --mode production",
"start": "webpack serve --mode development",
"lint": "eslint ./src/*",
"lint": "eslint src",
"test": "npx playwright test -c ../../playwright.config.ts",
"copy-sample-to-container": "../../tests/core/scripts/copy-sample-to-container.sh sample-actions-bar-plugin"
},
Expand All @@ -39,11 +39,11 @@
"@babel/preset-env": "^7.21.5",
"@babel/preset-react": "^7.18.6",
"@types/react-dom": "^18.2.6",
"@typescript-eslint/eslint-plugin": "^6.2.0",
"@typescript-eslint/parser": "^6.2.0",
"@typescript-eslint/eslint-plugin": "^8.71.1",
"@typescript-eslint/parser": "^8.71.1",
"babel-loader": "^9.1.2",
"copy-webpack-plugin": "^14.0.0",
"css-loader": "^6.7.4",
"copy-webpack-plugin": "^12.0.2",
"eslint": "^8.45.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-airbnb-base": "^15.0.0",
Expand All @@ -52,6 +52,6 @@
"typescript": "^5.1.3",
"webpack": "^5.83.1",
"webpack-cli": "^5.1.1",
"webpack-dev-server": "^4.15.1"
"webpack-dev-server": "^5.2.6"
}
}
6 changes: 4 additions & 2 deletions samples/sample-actions-bar-plugin/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable @typescript-eslint/no-var-requires */
/* eslint-disable @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports */
const CopyWebpackPlugin = require('copy-webpack-plugin');
const path = require('path');

Expand All @@ -20,7 +20,7 @@ module.exports = {
client: {
overlay: false,
},
onBeforeSetupMiddleware: (devServer) => {
setupMiddlewares: (middlewares, devServer) => {
if (!devServer) {
throw new Error('webpack-dev-server is not defined');
}
Expand All @@ -29,6 +29,8 @@ module.exports = {
devServer.app.get('/manifest.json', (req, res) => {
res.sendFile(path.resolve(__dirname, 'manifest.json'));
});

return middlewares;
},
},
module: {
Expand Down
Loading
Loading