Skip to content

fix check of invalid jwt.encode parameters from twitcher.oauth2.CustomTokenValidator - #153

Merged
fmigneault merged 1 commit into
masterfrom
fix-custom-token-generator
Sep 2, 2026
Merged

fmigneault merged 1 commit into
masterfrom
fix-custom-token-generator

Conversation

@fmigneault

Copy link
Copy Markdown
Member

An incorrectly configured token validator (such as in the tests) would result in failure when invoking the token generation. They will be raised upon initialization to allow early catch of the problem.

FAILED tests/functional/test_oauth2_app.py::OAuth2AppTests::test_compute_with_header - TypeError: Issuer (iss) must be a string.
FAILED tests/functional/test_oauth2_app.py::OAuth2AppTests::test_compute_with_param - TypeError: Issuer (iss) must be a string.

Error seen during #152 CI runs.

@fmigneault
fmigneault requested a review from cehbrecht August 24, 2026 22:43
@fmigneault fmigneault self-assigned this Aug 24, 2026

@cehbrecht cehbrecht left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... when tests pass :)

@fmigneault

Copy link
Copy Markdown
Member Author

@cehbrecht
Do you want me to create a PR that combines everything? They are interlocking each other because of pkg_resource #149

I also see that CodeCov complains about a missing token.
I sent a request to accept in bird-house org. I do not have access to enable it myself.

@fmigneault fmigneault mentioned this pull request Sep 1, 2026
@Zeitsperre

Copy link
Copy Markdown
Member

@fmigneault Message received. Check your organisation status.

Codecov is currently installed and enabled for all repositories. If you could specify under the GitHub app permissions which repos specifically need Codecov, both @tlvu and I would be happy.

Let me know if you need anything else.

@fmigneault

Copy link
Copy Markdown
Member Author

@Zeitsperre
Thanks. Got it. I'll test if the updated token works with the installed app.

fmigneault added a commit that referenced this pull request Sep 2, 2026
@fmigneault
fmigneault merged commit d90cd13 into master Sep 2, 2026
12 of 37 checks passed
@fmigneault
fmigneault deleted the fix-custom-token-generator branch September 2, 2026 17:25
@tlvu

tlvu commented Sep 2, 2026

Copy link
Copy Markdown

If you could specify under the GitHub app permissions which repos specifically need Codecov, both @tlvu and I would be happy.

@fmigneault
Yes, please selectively enable Codecov for the repos that need it only, not for all repos, which would also automatically include future private repos, we don't want that !

@fmigneault

Copy link
Copy Markdown
Member Author

@tlvu Yes. It is enabled only for this repo. Others need to added it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants