MB-72554: Handle deprecated analysis components - #2403
Open
Samsonnyyeet wants to merge 1 commit into
Open
Samsonnyyeet wants to merge 1 commit into
Samsonnyyeet wants to merge 1 commit into
Conversation
Analysis components (analyzers, tokenizers, token maps, token filters) can be removed from the registry over time. Previously, an index built with one of these would become impossible to open, rebuild, or query, since lookups failed with a plain "not registered" error. Now such a name is reported as deprecated instead. Opening, rebuilding, and indexing continue to work for an existing mapping that references one, with affected fields indexed without analysis. Queries that need to analyze text with a deprecated component still fail, but with an error that identifies it as deprecated rather than unknown. New mappings should reject these components by checking Validate's error for registry.ErrDeprecatedComponent.
|
coverage: 51.888% (+0.2%) from 51.688% — MB-72554-hebmorph-deprecated-validate into master |
Samsonnyyeet
requested review from
Likith101,
Thejas-bhat,
capemox,
maneuvertomars and
steveyen
October 1, 2026 10:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis components (analyzers, tokenizers, token maps, token filters) can be removed from the registry over time. Previously, an index built with one of these would become impossible to open, rebuild, or query, since lookups failed with a plain "not registered" error.
Now such a name is reported as deprecated instead. Opening, rebuilding, and indexing continue to work for an existing mapping that references one, with affected fields indexed without analysis. Queries that need to analyze text with a deprecated component still fail, but with an error that identifies it as deprecated rather than unknown. New mappings should reject these components by checking Validate's error for registry.ErrDeprecatedComponent.