Repository navigation
Conversation
fhgffy
marked this pull request as ready for review
October 6, 2026 12:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
download()queries RUNNING, PAUSED and PENDING downloads, but its matching-row check only returns early for RUNNING/PENDING. A paused download therefore falls through toenqueue()when the user requests the same URL or filename again.Include PAUSED in the existing
onDownloading()/early-return branch. Android defines this status as waiting to retry or resume, so the existing job is still active: https://developer.android.com/reference/android/app/DownloadManager#STATUS_PAUSEDReproduction and checks:
Downloader.ktandLatestVersionInfo.ktwith Kotlin 2.4.10 and Java 21 in an external host-JVM harnessonDownloading()oncegit diff --checkpassesAndroid/Compose boundaries are test doubles. This external harness is not a committed Android test target and does not test the actual DownloadProvider, network resumption or concurrency. Full Gradle/Android build, lint, emulator/device and UI interruption checks have not been run. Existing URL-or-title matching and completed-download behavior are unchanged.