Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions src/unified.rs
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,11 @@ where
std::iter::from_fn(move || {
for line in iter_lines.by_ref() {
if line == NO_NL {
// A repeated or leading marker has nothing to strip; it is not fatal.
if let Some(last) = last_line.as_mut() {
assert!(last.ends_with(b"\n"));
// Drop the last newline from `last`
*last = &last[..last.len() - 1];
} else {
panic!("No newline indicator without previous line");
if let Some(stripped) = last.strip_suffix(b"\n") {
*last = stripped;
}
}
} else {
if let Some(last) = last_line.take() {
Expand Down Expand Up @@ -162,6 +161,26 @@ fn test_iter_lines_handle_nl() {
assert_eq!(iter.next(), None);
}

#[test]
fn test_iter_lines_handle_nl_repeated_marker() {
let lines = vec![
&b"line 1\n"[..],
&b"\\ No newline at end of file\n"[..],
&b"\\ No newline at end of file\n"[..],
];
let mut iter = iter_lines_handle_nl(lines.into_iter());
assert_eq!(iter.next(), Some("line 1".as_bytes()));
assert_eq!(iter.next(), None);
}

#[test]
fn test_iter_lines_handle_nl_leading_marker() {
let lines = vec![&b"\\ No newline at end of file\n"[..], &b"line 1\n"[..]];
let mut iter = iter_lines_handle_nl(lines.into_iter());
assert_eq!(iter.next(), Some("line 1\n".as_bytes()));
assert_eq!(iter.next(), None);
}

static BINARY_FILES_RE: once_cell::sync::Lazy<regex::bytes::Regex> =
once_cell::sync::Lazy::new(|| {
lazy_regex::BytesRegex::new(r"^Binary files (.+) and (.+) differ").unwrap()
Expand Down