Repository navigation
Conversation
Owner
|
@trusche this looks useful thanks! Please resolve the CI errors and I'll merge. |
Author
I tried in #126 😄 I think they're all unrelated, it's just that CI is set to fail-fast. Same failures happen on master. It first failed on Rubocop, I threw a fix in for that, now it's the Cucumber incompatibility:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Workers pull jobs from a shared queue, so a worker that finishes early can run a second job in the same process.
Flatware::RSpec.runends each job with::RSpec.reset, which setsRSpec.configurationtonil. On the next job--require spec_helperis a no-op (already required), so the new configuration has none of theconfig.includes or hooks fromspec_helper. Specs then fail with errors likeundefined method 'stub_request'(WebMock), missing FactoryBot methods, and so on.Because it depends on worker timing, it shows up as intermittent failures, which is happening to us a lot recently.
Fix: use
::RSpec.clear_examplesinstead. It clears the example groups and reporter (so nothing runs twice) but keeps the configuration.Added a test that reproduce the issue by running two jobs through
Flatware::RSpec.runin one subprocess against aspec_helperthat includes a helper module.Disclosure: Built with Claude, but manually verified and submitted.