Skip to content

pass-an_optional_classification_value_passes_if_null #417

Open

Description

@rubendel

I think this test case is meant to be checking whether an attached classification without an actual value passes an optional classification requirement. However the checked object (IfcWall) does not have a linked classification at all (and should fail I think). Could it be that it is actually the IfcProject entity that should be checked instead of the IfcWall entity?

Activity

  1. atomczak commented on Jun 11, 2025

    @atomczak
    Member

    I think the problem lies elsewhere.

    The IFC file IfcClassification is missing the required 'Name' attribute (4th):

    Lack of Name causes it to pass because the pattern "\w+" misses the name check.

    In the case of an optional classification facet with value and system, the specification passes if the system does not appear in the IFC object, which is the case in the provided file. See the interpretation table that we decided to add:
    https://github.com/buildingSMART/IDS/blob/e1b39e0957abe8ec8cfc4ccb622e254622103d57/Documentation/UserManual/classification-facet.md#requirements

    • to do: add IfcClassification a Name that doesn't match the IDS pattern. This should then pass.
  2. self-assigned this
    on Jun 11, 2025
  3. added theissue type on Jun 11, 2025
  4. removed theissue type on Jun 11, 2025
  5. added this to the 1.0 milestone on Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions