Repository navigation
Conversation
cabljac
added this pull request to stack #116
October 14, 2026 14:22
cabljac
force-pushed
the
noninteractive/05-clone-public-fork
branch
from
October 14, 2026 23:16
6749ea0 to
01049cd
Compare
cabljac
force-pushed
the
noninteractive/05-clone-public-fork
branch
from
October 15, 2026 01:10
01049cd to
cf416f0
Compare
cabljac
marked this pull request as ready for review
October 16, 2026 08:55
clone gains --public-fork <url> (URL or owner/repo) for mirrors without a venfork-config branch. It replaces the public fork guess and prompt, and the upstream parent lookup then runs on that fork, not on the mirror owner. With a config branch the flag must name the recorded fork, like --upstream; both now compare by repository, so another URL form of the same repo is accepted. --public-fork with --no-public, or on a no-public config, is refused. The public fork prompt without a TTY now names --public-fork <url>. Every clone prompt cancel exits 130, and the fork and upstream prompts reject an empty answer through validate. The parent lookup passed --jq '.parent.url' with literal quotes to gh, so upstream auto-detection always fell through to the prompt. Fixed. setup: --org set to your own gh username (compared ignoring case) counts as consent and skips the personal-account confirm. VENFORK_ORG set to your username is ambient, so it does not.
cabljac
force-pushed
the
noninteractive/05-clone-public-fork
branch
from
October 17, 2026 17:07
cf416f0 to
c325392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a legacy mirror with no venfork-config branch, clone guessed the public fork and, without a TTY, failed naming the wrong flag. This adds
clone --public-fork <url>(URL orowner/repo). It replaces the guess and the prompt. With a config branch it must name the recorded fork, and it is refused with--no-public. Clone prompt cancels exit 130, and empty answers are rejected. The parent lookup passed its jq filter to gh with literal quotes, so auto-detection never worked; that is fixed.setup: only the flag
--org <own username>counts as consent for the personal account, compared without case.VENFORK_ORGset to your username still needs--yeswithout a TTY.Red-first: an integration test that deletes the fixture's config branch and clones through a gh stub, a no-TTY test for exit 2 naming
--public-fork, and "VENFORK_ORG set to own username still needs --yes without a TTY".bun run verifyexits 0. Drove clone.md. Count gate: unit 999 to 1021, integration 323 to 325.Not verified: e2e tiers.
Part of the 0.13.0 non-interactive and portable stack.