Skip to content

fix(telemetry): keep honoring NEEDLE_TELEMETRY=0 after the rename - #192

Closed
antcybersec wants to merge 1 commit into
cactus-compute:mainfrom
antcybersec:fix/telemetry-legacy-optout
Closed

antcybersec wants to merge 1 commit into
cactus-compute:mainfrom
antcybersec:fix/telemetry-legacy-optout

Conversation

@antcybersec

Copy link
Copy Markdown

#186 renamed the telemetry opt-out from NEEDLE_TELEMETRY to CACTUS_TELEMETRY. Anyone who turned telemetry off with NEEDLE_TELEMETRY=0, as the old README and llms.txt said to, is now opted back in without noticing. llms.txt still documents NEEDLE_TELEMETRY=0 as the opt-out:

$ NEEDLE_TELEMETRY=0 python -c "from cactus import _telemetry; print(_telemetry._enabled())"
True
  • _enabled() also treats NEEDLE_TELEMETRY=0 as an opt-out.
  • llms.txt documents CACTUS_TELEMETRY=0 (and notes the old name still works).
  • New tests/test_telemetry.py covers the default and every opt-out (CACTUS_TELEMETRY=0, NEEDLE_TELEMETRY=0, DO_NOT_TRACK=1, CI).

Testing: pytest -q tests/test_telemetry.py (the NEEDLE_TELEMETRY case fails on main), and the full pytest -q passes (273 passed, 13 skipped).

cactus-compute#186 renamed the opt-out from NEEDLE_TELEMETRY to CACTUS_TELEMETRY. Users
who turned telemetry off with NEEDLE_TELEMETRY=0, as the old README and
llms.txt told them to, were silently opted back in, and llms.txt still
documents NEEDLE_TELEMETRY=0 as the way to opt out.

Treat NEEDLE_TELEMETRY=0 as an opt-out too, document CACTUS_TELEMETRY=0 in
llms.txt, and add tests for every opt-out.

Signed-off-by: anant <170962632+antcybersec@users.noreply.github.com>
@jakmro

jakmro commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Thank you @antcybersec for spotting this. We fixed the docs in #198 to point to CACTUS_TELEMETRY=0. The package is fully renamed now, so we would rather keep consistent naming. Closing this one.

@jakmro jakmro closed this Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants