Repository navigation
fix(telemetry): keep honoring NEEDLE_TELEMETRY=0 after the rename - #192
Closed
antcybersec wants to merge 1 commit into
Closed
antcybersec wants to merge 1 commit into
antcybersec wants to merge 1 commit into
Conversation
cactus-compute#186 renamed the opt-out from NEEDLE_TELEMETRY to CACTUS_TELEMETRY. Users who turned telemetry off with NEEDLE_TELEMETRY=0, as the old README and llms.txt told them to, were silently opted back in, and llms.txt still documents NEEDLE_TELEMETRY=0 as the way to opt out. Treat NEEDLE_TELEMETRY=0 as an opt-out too, document CACTUS_TELEMETRY=0 in llms.txt, and add tests for every opt-out. Signed-off-by: anant <170962632+antcybersec@users.noreply.github.com>
Contributor
|
Thank you @antcybersec for spotting this. We fixed the docs in #198 to point to CACTUS_TELEMETRY=0. The package is fully renamed now, so we would rather keep consistent naming. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#186 renamed the telemetry opt-out from
NEEDLE_TELEMETRYtoCACTUS_TELEMETRY. Anyone who turned telemetry off withNEEDLE_TELEMETRY=0, as the old README andllms.txtsaid to, is now opted back in without noticing.llms.txtstill documentsNEEDLE_TELEMETRY=0as the opt-out:_enabled()also treatsNEEDLE_TELEMETRY=0as an opt-out.llms.txtdocumentsCACTUS_TELEMETRY=0(and notes the old name still works).tests/test_telemetry.pycovers the default and every opt-out (CACTUS_TELEMETRY=0,NEEDLE_TELEMETRY=0,DO_NOT_TRACK=1,CI).Testing:
pytest -q tests/test_telemetry.py(theNEEDLE_TELEMETRYcase fails onmain), and the fullpytest -qpasses (273 passed, 13 skipped).