fix(ci): a ddebs outage must not fail the profiling image - #3937
Merged
Merged
Conversation
`Release Merod Profiling container` failed on master at the rc.37 release
commit:
E: Some index files failed to download. They have been ignored, or old ones
used instead.
ERROR: failed to solve: ... exit code: 100
ddebs.ubuntu.com was briefly unreachable. It answers 200 now and the six
previous release runs all passed, so the outage was transient — but the image
should not have died for it, and the Dockerfile already says so:
If ddebs hasn't mirrored the matching dbgsym yet, the install is allowed to
fail non-fatally (`|| echo`): libc6-dbg above already covers the bulk of
[unknown] frames, so a missing libgcc/libstdc++ dbgsym degrades flamegraph
detail slightly rather than breaking the image.
That guard was one line too late. It wraps the INSTALL; the `apt-get update`
that pulls the ddebs index sat unguarded directly above it, so the stated
intent — optional symbols, never a broken image — held for a missing package
but not for a missing index. ddebs is a third-party archive with no
availability guarantee, and either way of being absent should be survivable.
The index fetch is now tolerated, and on failure the ddebs source is REMOVED
and apt updated again rather than `|| true`-ing the whole thing. That keeps the
main Ubuntu archive fatal: this update refreshes every source, so swallowing it
wholesale would hide a real archive outage as well as a ddebs one. The
subsequent dbgsym install then fails into the existing `|| echo`, which is
exactly the degraded path that was already designed for.
`Acquire::Retries=3` covers the brief case before either path is taken.
Verified: the joined RUN body passes `sh -n`, and a simulated failing update
takes the fallback, removes the source and continues.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chefsale
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Merod Profiling containerfailed on master at the rc.37 release commit (run 34971598136):What happened
ddebs.ubuntu.comwas briefly unreachable. It answers200now and the six previous release runs all passed, so the outage was transient — but the image should not have died for it, and the Dockerfile already says so:That guard was one line too late. It wraps the install; the
apt-get updatethat pulls the ddebs index sat unguarded directly above it. So the stated intent held for a missing package but not for a missing index — and ddebs is a third-party archive with no availability guarantee, where either way of being absent should be survivable.The fix
&& ( apt-get update -o Acquire::Retries=3 \ || { echo "[image] WARN: ddebs.ubuntu.com index unavailable — dropping the source and continuing..."; \ rm -f /etc/apt/sources.list.d/ddebs.list; \ apt-get update -o Acquire::Retries=3; } ) \On failure the ddebs source is removed and apt updated again, rather than
|| true-ing the whole thing. That matters: this update refreshes every source, so swallowing it wholesale would hide a real Ubuntu archive outage as well as a ddebs one. The main archive stays fatal.The subsequent dbgsym install then fails into the existing
|| echo— the degraded path that was already designed for.Acquire::Retries=3covers the brief case before either path is taken.Verification
RUNbody passessh -n(valid POSIX shell)Note
This is the same class as the Browser E2E breakage in
appsa while back: a third-party apt index going down and taking an unrelated build with it. Worth watching for elsewhere — any unguardedapt-get updateafter adding a non-Ubuntu source has this shape.🤖 Generated with Claude Code