Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
`metro prepare` read `--kind ?? --metro-kind`, so one option had two spellings. The reader now reads `--kind` only, and `--metro-kind` stays in connect's `--metro-*` hint family, which names the launcher kind deferred Metro preparation runs with. The shared METRO_PREPARE_FLAGS declaration splits so metro no longer allows metroKind while connect still does; the saved remote-config/profile `metroKind` field is unchanged. `diff snapshot` reports text and never writes a file, so `out` leaves the CaptureDiffOptions type, the diff command's input metadata, and the CLI reader. `--out` still names the diff PNG for `diff screenshot` and `screenshot`.
e0f9103 to
f6aa4e1
Compare
Size Report
Startup median (7 runs, lower is better):
|
Apex Sentinel · ✅ Approve · review of
|
| Command | What it does |
|---|---|
@apex-sentinel-staging note <context> |
Adds context; Sentinel re-checks the cited code |
@apex-sentinel-staging pivot <why> |
Says the finding is wrong; Sentinel re-checks the cited code |
@apex-sentinel-staging like |
Marks the finding as useful |
@apex-sentinel-staging dislike <why> |
Marks it as not useful, so it is not raised again |
On this conversation, comment @apex-sentinel-staging review to run a full review once again.
|
The code in f6aa4e1 is ready: removing |
Summary
Two breaking cleanups for 0.22.
metro preparetook its launcher kind under two spellings: the reader used--kind ?? --metro-kind. Only--kindremains.--metro-kindstays inconnect's--metro-*hint family, which names the kind deferred Metro preparation runs with; the saved remote-config/profilemetroKindfield is unchanged. The sharedMETRO_PREPARE_FLAGSdeclaration is split, sometrono longer allowsmetroKindwhileconnectstill does.diff snapshotreports text and never writes a file, sooutleaves the Node client'sCaptureDiffOptions, thediffcommand's input metadata, and the CLI reader.--outstill names the diff PNG fordiff screenshotand forscreenshot.When main is next merged into 0.22, drop
metroKindfrom metro'sflagsByAction.prepare(added on main by #4893) so the alias stays removed.Before / after
Value
diffinput-schema propertiesValidation
Head
f6aa4e1664.pnpm check:affected --run --head f6aa4e1664passes format, lint, typecheck, layering, di-seams, fallow, native-dupes, mcp-metadata and build, then stops atpackage.vitest-relatedandpackagefail only on host-local process timeouts (osascriptSIGKILL in the web package smoke; the release-publish, release-assets and plugin-store tests), each reproduced on the unchanged base, so GitHub CI owns them.check:command-docsandcheck:doc-prosepass aftergenerate:command-docs. Focused lanes pass: parser, command-surface capture/metro/schema,cli-diff,cli-client-commands, MCP input docs, option-schema support map. No device-facing change.🤖 Generated with Claude Code