Repository navigation
Add forward containment traversal for touched roots - #24
Merged
Merged
Conversation
Add explicit subtree invalidation roots, forward graph traversal, and containment test selection/output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This PR adds explicit containment-based test selection for touched app roots. Sniffler can now mark a module as a subtree root via
tests.invalidateSubtreeWhenTouched, so changes inside shared code can still fan out through a designated root likesrc/App.tsxand select tests below it.How does it work?
Sniffler still runs normal reverse dependency traversal first. After that, it checks touched modules against the new path or glob rules. For each matched root, it walks forward through the existing import graph, records the shortest containment path, and matches tests against the reachable declared targets. Text and JSON output now distinguish dependency reasons from containment reasons, and config loading validates and defaults the new option.
Why is this useful?
tests/benchmark.bench.ts:shared-root67.3052 hz,deep-branch94.5765 hz.Closes #22.