Skip to content

Remove deprecated Path contextmanager (bugfix) - #3039

Merged
Hook25 merged 1 commit into
mainfrom
fix_path_contextlib
Nov 11, 2026
Merged

Hook25 merged 1 commit into
mainfrom
fix_path_contextlib

Conversation

@Hook25

@Hook25 Hook25 commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Tox python3.14 found a n+1 issue, the contextmanger was removed in python3.13

Resolved issues

N/A

Documentation

N/A

Tests

N/A

Copilot AI lite review requested due to automatic review settings November 10, 2026 17:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.46%. Comparing base (0db3ce3) to head (bd49e68).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3039   +/-   ##
=======================================
  Coverage   62.45%   62.46%           
=======================================
  Files         508      508           
  Lines       51448    51443    -5     
  Branches     9040     9032    -8     
=======================================
  Hits        32134    32134           
+ Misses      18464    18459    -5     
  Partials      850      850           
Flag Coverage Δ
provider-base 43.09% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fernando79513 fernando79513 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are passing, and the changes are straightforward, so

LGTM +1!

@Hook25
Hook25 merged commit ca17ad4 into main Nov 11, 2026
26 of 28 checks passed
@Hook25
Hook25 deleted the fix_path_contextlib branch November 11, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants