Skip to content

chore: fix mypy issues in config/tests - #7059

Open
sshedi wants to merge 20 commits into
canonical:mainfrom
sshedi:fix-mypy-config-tests
Open

chore: fix mypy issues in config/tests#7059
sshedi wants to merge 20 commits into
canonical:mainfrom
sshedi:fix-mypy-config-tests

Conversation

@sshedi

@sshedi sshedi commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Proposed Commit Message

chore: fix mypy issues in config tests

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

holmanb
holmanb requested changes Sep 1, 2026
View reviewed changes
Comment thread tests/unittests/config/test_apt_configure_sources_list_v3.py Outdated
@sshedi
sshedi force-pushed the fix-mypy-config-tests branch 4 times, most recently from 35bb43c to 0745339 Compare September 4, 2026 14:51
@sshedi
sshedi force-pushed the fix-mypy-config-tests branch 3 times, most recently from 6deee13 to 13c43a0 Compare September 16, 2026 11:34
@sshedi
sshedi force-pushed the fix-mypy-config-tests branch 3 times, most recently from 685a41b to 691da13 Compare September 27, 2026 05:39
holmanb
holmanb requested changes Sep 28, 2026
View reviewed changes

@holmanb holmanb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @sshedi. This is going the right direction, but there are a few things that need to be addressed before this can merge.

Comment thread tests/unittests/config/test_cc_growpart.py Outdated
Comment thread tests/unittests/config/test_modules.py Outdated
Comment thread tests/unittests/config/test_modules.py Outdated
Comment thread tests/unittests/config/test_cc_rh_subscription.py Outdated
Comment thread tests/unittests/config/test_cc_growpart.py Outdated
Comment thread tests/unittests/config/test_cc_zypper_add_repo.py
@sshedi
sshedi force-pushed the fix-mypy-config-tests branch from 691da13 to 867e764 Compare September 28, 2026 16:08
sshedi and others added 17 commits October 8, 2026 09:52
@sshedi @claude
typing: fix mypy annotation errors in test_apt_configure_sources_list_v3
cb7477b 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_apt_source_v1
5f8bb05 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_apt_pipelining
1d41ed8 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_chef
6c96a96 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_final_message
27d48ac 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_growpart
d6ee2ff 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_install_hotplug
49fc303 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_keys_to_console
6fe3844 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_puppet
eca27d5 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_resizefs
5b915f0 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_resolv_conf
8988a8e 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_rh_subscription
1130915 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_ubuntu_autoinstall
f5f5779 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_update_etc_hosts
44c4f0b 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_users_groups
1be671d 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_wireguard
ae77418 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_cc_yum_add_repo
9d199a0 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
sshedi and others added 3 commits October 8, 2026 09:52
@sshedi @claude
typing: fix mypy annotation errors in test_cc_zypper_add_repo
1e4f4bf 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_modules
fb85529 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi @claude
typing: fix mypy annotation errors in test_schema
4bd2a20 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
@sshedi
sshedi force-pushed the fix-mypy-config-tests branch from 867e764 to 4bd2a20 Compare October 8, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holmanb holmanb holmanb requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sshedi @holmanb @blackboxsw