Repository navigation
prevent tunnel sockets from overwriting existing files - #1141
Open
shizuku198411 wants to merge 2 commits into
Open
shizuku198411 wants to merge 2 commits into
shizuku198411 wants to merge 2 commits into
Conversation
Contributor
|
I think we should overwrite the file if it's another socket; it could be left over from another session that closed abruptly. But if it's a regular file we should probably avoid deleting it, yes. |
Contributor
Author
|
I agree, allowing existing sockets to be overwritten makes sense. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1140
Prevent the tunnel interface from overwriting existing files when creating a Unix socket.
Previously, Workshop could replace an existing regular file with a Unix socket during tunnel setup, potentially causing data loss.
This PR adds an
os.Lstat()check to reject socket creation if the target path already exists, regardless of its file type.Changes:
Verification:
start,stop, andrefreshcontinue to work as expected.Self-review quick check
Docs