refactor(sql): disable double-quoted string literals - #8689
Merged
Merged
Conversation
link2xt
marked this pull request as ready for review
September 15, 2026 12:10
link2xt
force-pushed
the
link2xt/sql-disable-dqs
branch
from
September 16, 2026 19:19
ec7b67d to
9235706
Compare
hpk42
reviewed
Sep 17, 2026
Comment on lines
+746
to
+747
| conn.set_db_config(rusqlite::config::DbConfig::SQLITE_DBCONFIG_DQS_DML, false)?; | ||
| conn.set_db_config(rusqlite::config::DbConfig::SQLITE_DBCONFIG_DQS_DDL, false)?; |
Contributor
There was a problem hiding this comment.
Dbconfig is top-level imported.
hpk42
approved these changes
Sep 17, 2026
hpk42
left a comment
hpk42
left a comment
Contributor
There was a problem hiding this comment.
fine but maybe address the one nit.
Double-quoted string literals are not standard and may be accidentally treated as an identifier if there is an identifier with the same name as the string contents: https://sqlite.org/quirks.html#double_quoted_string_literals_are_accepted
link2xt
force-pushed
the
link2xt/sql-disable-dqs
branch
from
September 17, 2026 12:29
9235706 to
dafcdee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double-quoted string literals are not standard
and may be accidentally treated as an identifier
if there is an identifier with the same name
as the string contents:
https://sqlite.org/quirks.html#double_quoted_string_literals_are_accepted