build(deps-dev): bump vitest from 4.1.11 to 5.0.0 - #336
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
Deploying podnotes with
|
| Latest commit: |
e3ebae7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6c9a6c9.podnotes.pages.dev |
| Branch Preview URL: | https://dependabot-npm-and-yarn-vite.podnotes.pages.dev |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Do not merge. This is a Dependabot build(deps-dev) major bump of Vitest 4.1.11 → 5.0.0. The diff is only package.json + package-lock.json, and the title will not cut a plugin release — but GitHub Test is already red, so this is not a drop-in upgrade.
CI regression (blocking)
Test / Type check failed before lint/build/test ran. tsc --project tsconfig.test.json --noEmit reports dozens of errors such as:
Property 'toBeInTheDocument' does not exist on type 'Assertion<void, HTMLElement>'- same for
toBeDisabled,toHaveClass,toBeVisible,toHaveAttribute
in PodcastView.integration.test.ts, TopBar.test.ts, ReorderQueue.test.ts, Image.test.ts, Progressbar.test.ts, PlaylistManager.test.ts, and PodcastResultCard.test.ts.
Why
Vitest 5 inlined expect and changed matcher types to Assertion<R, T> / Matchers<R, T> (R is the return type, T is the received value). It also stopped reading jest.Matchers. @testing-library/jest-dom@7.0.1 still augments the old one-parameter Assertion<T>, so those matchers disappear from TypeScript even though runtime registration might still work.
The current setup also imports @testing-library/jest-dom rather than @testing-library/jest-dom/vitest. That was enough under Vitest 4; it is not a Vitest 5-ready integration.
Other migration work this PR does not do
Prerequisites are already met (engines.node is ^22.22.2, Vite is ^8.2.2). The remaining 5.0 breaks that can still hit this suite after types are fixed:
clearMocksnow defaults totrue(vi.clearAllMocks()before each test). Sharedvi.fn()history across tests will change.- Unawaited
.resolves/.rejectsnow fail the test. vi.mock/vi.hoisted/vi.unmocknow throw if they are not at module top level (current uses look top-level, but that needs a full run to confirm).
What a mergeable upgrade needs
A dedicated Vitest 5 migration, not this lockfile-only bump:
- Switch the setup import to
@testing-library/jest-dom/vitestand shipMatchers<R, T>/Assertion<R, T>augmentations (jest-dom 7.0.1 types onmainstill useAssertion<T>). - Re-run
npm ci,lint,format:check,typecheck,build,test(andsvelte-check) on Node 22. - Review mock-call assertions against the new
clearMocksdefault; setclearMocks: falseonly if we intentionally keep v4 behavior. - Keep GitHub
Testgreen.
Until that lands, leave this PR unmerged. @dependabot ignore this major version is reasonable until jest-dom types catch up.
Sent by Cursor Automation: Dependabot PRs
| "typescript": "6.0.3", | ||
| "vite": "^8.2.2", | ||
| "vitest": "^4.1.11", | ||
| "vitest": "^5.0.0", |
There was a problem hiding this comment.
This is the blocking line. Vitest 5 changes Assertion to Assertion<R, T> and stops reading jest.Matchers. @testing-library/jest-dom@7.0.1 still augments Assertion<T>, which is why tsconfig.test.json typecheck fails on toBeInTheDocument / toBeDisabled / similar matchers across the Svelte component tests. A version pin here is not enough; the upgrade needs a matcher-type + setup-file migration and a green Test run.
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.1.11 to 5.0.0. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.0/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-version: 5.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
de2b0a6 to
e3ebae7
Compare
Bumps vitest from 4.1.11 to 5.0.0.
Release notes
Sourced from vitest's releases.
... (truncated)
Commits
f441c6fchore: release v5.0.0 (#11130)d46a747fix: treat test.describe as a suite during static collection (#11128)584cf30fix: add a warning if inline project has duplicate plugins due to unexpected ...f08ce4bfix: apply queued mocks from doMock() in queue order (fixes #10706) (#11127)897f51fchore: release v5.0.0-rc.4 (#11107)1339b06chore(deps): update all non-major dependencies (#11104)51e9494feat!: parse files statically in vitest list by default (#11088)2122ffdfix: propagate --maxWorkers to projects (#11102)dc10f5ffix(browser): report the action error when a task times out (#11101)d4fe198feat: promote clearCache out of experimental (#11086)