Skip to content

Make the new render dump save methods non-static. #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leMaik merged 1 commit into from
Sep 5, 2026
Merged

Make the new render dump save methods non-static. #1912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions chunky/src/java/se/llbit/chunky/renderer/renderdump/RenderDump.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,22 +115,22 @@ public static void save(OutputStream outputStream, Scene scene, TaskTracker task

@PluginApi
public static void save(OutputStream outputStream, Scene scene, TaskTracker taskTracker, int version) throws IOException {
save(outputStream, new RenderDump(scene), taskTracker, version);
new RenderDump(scene).save(outputStream, taskTracker, version);
}

@PluginApi
public static void save(OutputStream outputStream, RenderDump dump, TaskTracker taskTracker, int version) throws IOException {
save(outputStream, dump, taskTracker, getDumpFormat(version));
public void save(OutputStream outputStream, TaskTracker taskTracker, int version) throws IOException {
save(outputStream, taskTracker, getDumpFormat(version));
}

@PluginApi
public static void save(OutputStream outputStream, RenderDump dump, TaskTracker taskTracker, DumpFormat format) throws IOException {
public void save(OutputStream outputStream, TaskTracker taskTracker, DumpFormat format) throws IOException {
DataOutputStream dataOutputStream = new DataOutputStream(new BufferedOutputStream(outputStream));
if (format.getVersion() != 0) {
dataOutputStream.write(DUMP_FORMAT_MAGIC_NUMBER);
dataOutputStream.writeInt(format.getVersion());
}
format.save(dataOutputStream, dump, taskTracker);
format.save(dataOutputStream, this, taskTracker);
dataOutputStream.flush();
}

Expand Down
Loading