Repository navigation
Conversation
this is correct, as shortString variable is expected to contain a terminated string (7 chars max+nt) |
Collaborator
Author
Let's not now combine source and destination terms together. Since the max len is defined by parameter type enforcing terminator is wasting one potential character. Here is list of references to string param read function: |
…ring game session cleanup
MiranDMC
force-pushed
the
String_param_parsing_update
branch
from
October 4, 2026 10:34
5f7334f to
175c2b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beside expected script name related tests failing now there is also problem with in print string test:
as the
ais assignedFrom AC