Skip to content

GetScriptStringParam hook now enforces null-terminator - #601

Draft
MiranDMC wants to merge 6 commits into
masterfrom
String_param_parsing_update
Draft

MiranDMC wants to merge 6 commits into
masterfrom
String_param_parsing_update

Conversation

@MiranDMC

@MiranDMC MiranDMC commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Beside expected script name related tests failing now there is also problem with in print string test:

shortString a = 'From ACC' // 8 characters

as the a is assigned From AC

@x87

x87 commented Sep 26, 2026

Copy link
Copy Markdown

as the a is assigned From AC

this is correct, as shortString variable is expected to contain a terminated string (7 chars max+nt)

@MiranDMC

MiranDMC commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

as the a is assigned From AC

this is correct, as shortString variable is expected to contain a terminated string (7 chars max+nt)

Let's not now combine source and destination terms together. Since the max len is defined by parameter type enforcing terminator is wasting one potential character.

Here is list of references to string param read function:
ReadStringParamReferences.txt

@MiranDMC
MiranDMC force-pushed the String_param_parsing_update branch from 5f7334f to 175c2b4 Compare October 4, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants