fix(ui): reconnect Google One Tap accounts through Google OAuth - #9690
fix(ui): reconnect Google One Tap accounts through Google OAuth#9690akshitkrnagpal wants to merge 1 commit into
Conversation
- Preserve session reverification when reconnecting in UserProfile.
|
@akshitkrnagpal is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 9243dc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughUserProfile reconnect logic now maps Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Disconnected Google One Tap accounts now reconnect through Google OAuth, including after session reverification. The covered reconnect and retry behavior is ready to merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
Description
Fixes #9689: "UserProfile reconnect sends
google_one_tapinstead ofoauth_googlefor Google One Tap accounts".Reconnect now normalizes
google_one_taptooauth_google, allowing disconnected Google One Tap accounts to reconnect through regular Google OAuth. Session reverification remains in place, and the retry uses the normalized strategy.I've been using this patch, and it fixed the issue for me. I'm open to a different approach; this is the fix that has worked for me.
To verify, reconnect a disconnected Google One Tap account in UserProfile and complete session reverification. The request should use
oauth_googleand redirect to Google.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change