Repository navigation
fix(kitchen-sink): avoid black paper in fullscreen - #86
Merged
kumilingus merged 1 commit intoOct 19, 2026
Merged
Conversation
When the demo is embedded in an iframe, as on jointjs.com, fullscreen makes the iframe the fullscreen element and the browser paints a black backdrop behind it. The paper area had no background of its own, so the backdrop showed through. Opened directly, the browser's default white canvas hid the problem. Applied to all kitchen-sink variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87
Clicking fullscreen in the Kitchen Sink demo on https://www.jointjs.com/demos/kitchen-sink turns the paper area black.
Why
On jointjs.com the demo runs inside an iframe. Fullscreen then makes the
<iframe>the fullscreen element, and the browser paints a black backdrop behind it. The paper area (.paper-container) had no background of its own, so the backdrop showed through. Opened directly, the browser's default white canvas hid the problem, which is why it didn't reproduce locally.Changes
.paper-containernow setsbackground: var(--jj-bg-primary)(white) in all 7 kitchen-sink variants.Testing
Tested
kitchen-sink/tsin Chromium (Playwright), with the demo in an iframe:rgb(0, 0, 0), paper black.The other 6 variants get the identical one-line change but were not built or run.
🤖 Generated with Claude Code