Skip to content

refactor(nginx-strangler): route stages to server-nestjs - #2748

Open
shikanime wants to merge 3 commits into
pr/stage-migrationfrom
pr/stage-nginx-routing
Open

shikanime wants to merge 3 commits into
pr/stage-migrationfrom
pr/stage-nginx-routing

Conversation

@shikanime

Copy link
Copy Markdown
Member

What

Extract the nginx-strangler routing change (/api/v1/stages → server-nestjs) from #2496 into this standalone PR.

Why

Decouple the traffic-routing cut-over from the stage module migration so the nginx switch can land and be observed independently of #2496.

References

Depends on the server-nestjs stage routes from #2496; safe to merge only with or after it.

Signed-off-by: Shikanime Deva 22115108+shikanime@users.noreply.github.com

@shikanime
shikanime requested a review from a team as a code owner September 18, 2026 08:58
@github-actions github-actions Bot added the built label Sep 18, 2026
@shikanime
shikanime marked this pull request as draft September 18, 2026 09:20
@shikanime
shikanime changed the base branch from main to pr/admin-token-migration September 18, 2026 09:45
@shikanime
shikanime changed the base branch from pr/admin-token-migration to main September 18, 2026 09:45
@shikanime
shikanime changed the base branch from main to pr/stage-strangler September 18, 2026 09:46
@shikanime
shikanime added this pull request to stack #2554 September 18, 2026 09:46
@shikanime
shikanime removed this pull request from stack #2554 September 18, 2026 09:54
@shikanime
shikanime changed the base branch from pr/stage-strangler to pr/stage-migration September 18, 2026 09:54
@shikanime
shikanime added this pull request to stack #2753 September 18, 2026 09:54
@shikanime
shikanime marked this pull request as ready for review September 23, 2026 15:12
@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch from 45a917f to 0258166 Compare September 23, 2026 15:50
@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch from 0258166 to 9688320 Compare September 23, 2026 16:07
Ajoute le bloc `location /api/v1/stages` vers server-nestjs.

Refs #2493

Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: Id581b73ea4e9e30f9306f4cd308ec24c6a6a6964
@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch from 9688320 to 02fca72 Compare September 23, 2026 16:25
@shikanime shikanime added this to the 9.27.0 milestone Sep 24, 2026
@shikanime shikanime self-assigned this Sep 24, 2026
@shikanime shikanime added the preview Deploy preview app with Argo-cd label Sep 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

A preview of the application is available at : https://console-pr-2748.dso.cpin-hp.numerique-interieur.fr

Please be patient, deployment may take a few minutes.

StephaneTrebel
StephaneTrebel previously approved these changes Sep 24, 2026
UserGuard on the stage routes resolves AuthService through the importing module; without AuthModule the backend crashed at boot.

Co-authored-by: Automata <automata@shikanime.studio>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
UserGuard resolves UserPermissionService through the importing module as well; the guard crashed at boot with only AuthModule imported.

Co-authored-by: Automata <automata@shikanime.studio>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
@cloud-pi-native-sonarqube

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

built preview Deploy preview app with Argo-cd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants