Skip to content

test(admin-role): lock member counts against OIDC role ids #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shikanime merged 1 commit into from
Sep 29, 2026
Merged

test(admin-role): lock member counts against OIDC role ids #2783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions apps/server-nestjs/src/modules/admin-role/admin-role.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import type { EventEmitter2 } from '@nestjs/event-emitter'
import type { PrismaService } from '../infrastructure/database/prisma.service'
import { adminRoleContract } from '@cpn-console/shared'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { mockDeep } from 'vitest-mock-extended'
import { makeUser } from '../project/project-testing.utils'
import {
makeAdminRole,
makeCreateAdminRoleBody,
Expand Down Expand Up @@ -92,4 +94,24 @@ describe('adminRoleService', () => {
await expect(service.patch([patchedA, patchedB])).resolves.toBeDefined()
expect(eventEmitter.emitAsync).toHaveBeenCalledTimes(2)
})

it('counts members per managed role, ignoring OIDC role ids', async () => {
const managedRole = makeAdminRole({ oidcGroup: '' })
const otherManagedRole = makeAdminRole({ oidcGroup: '' })
const oidcRole = makeAdminRole({ oidcGroup: '/console/admin' })

prisma.adminRole.findMany.mockResolvedValue([managedRole, otherManagedRole])
prisma.user.findMany.mockResolvedValue([
makeUser({ adminRoleIds: [managedRole.id, oidcRole.id] }),
makeUser({ adminRoleIds: [managedRole.id, otherManagedRole.id] }),
])
prisma.$transaction.mockImplementation(async (cb: (tx: unknown) => unknown) => cb(prisma))

const service = new AdminRoleService(prisma, eventEmitter)
const counts = await service.memberCounts()

expect(counts).toEqual({ [managedRole.id]: 2, [otherManagedRole.id]: 1 })
expect(Object.values(counts).every(Number.isFinite)).toBe(true)
expect(adminRoleContract.adminRoleMemberCounts.responses[200].safeParse(counts).success).toBe(true)
})
})
Loading