Repository navigation
fix(image): fix custom-loader srcSet, support images.loaderFile #3686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AhmedElBanna80
wants to merge
26
commits into
cloudflare:main
Choose a base branch
from
AhmedElBanna80:fix/c3-image-shim-trailing-slash-srcset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
fdd4677
fix(image): honor trailingSlash, fix custom-loader srcSet, support im…
AhmedElBanna80 aa3ae0d
test(image): update shims.test.ts custom-loader assertions for per-br…
AhmedElBanna80 7f7f69c
fix(image): wire images.loaderFile without a root test alias and matc…
james-elicx 3f15479
Merge branch 'main' of https://github.com/cloudflare/vinext into pr-3686
james-elicx 8323621
fix(image): match Next.js for configured loaders on fill, overrideSrc…
james-elicx db8b569
fix(image): skip custom loaders for inline sources and keep src after…
james-elicx b27f365
fix(image): match Next.js loaderFile resolution and scope it to next/…
james-elicx ea6fda7
fix(image): keep priority, data-nimg and blur styles on custom-loader…
james-elicx c08f0b3
fix(image): treat empty sources as unoptimized and ignore caller srcSet
james-elicx 873ef69
refactor(image): share the unoptimized and custom loader render path
james-elicx c9602a2
Merge commit 'fc06b50345838ff94fdc54522ae078731b7cef91' into pr-3686-b
james-elicx d927ceb
fix(image): keep next/legacy/image from importing images.loaderFile
james-elicx 17031ff
test(image): cover trailingSlash, loader srcSet and loaderFile in the…
james-elicx 764c619
Merge branch 'main' of https://github.com/cloudflare/vinext into pr-3…
james-elicx 9445847
fix(image): never send data:, blob: or empty sources through /_next/i…
james-elicx ba15bbc
fix(image): keep next/legacy/image layout rules for custom-loader srcSet
AhmedElBanna80 a82b0bd
Merge remote-tracking branch 'upstream/main' into fix/c3-image-shim-t…
AhmedElBanna80 7f7e313
Merge remote-tracking branch 'upstream/main' into fix/c3-image-shim-t…
AhmadElBanna80 5c1389a
Merge remote-tracking branch 'origin/main' into HEAD
AhmedElBanna80 254502d
chore: re-run CI (Windows create-next-app job hung)
AhmedElBanna80 7f9bbff
ci: retrigger (codspeed installer download failed)
AhmedElBanna80 eded672
Merge main into fix/c3-image-shim-trailing-slash-srcset
AhmedElBanna80 1b771e5
Merge remote-tracking branch 'upstream/main' into up-3686
AhmedElBanna80 aff2b14
Merge main into fix/c3-image-shim-trailing-slash-srcset
AhmedElBanna80 620528e
Merge remote-tracking branch 'upstream/main' into m-c3-image-shim-tra…
AhmedElBanna80 ad41a5f
fix(image): keep images.loaderFile out of next/legacy/image
AhmedElBanna80 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.