Skip to content

fix(fonts): handle query suffixes in module IDs - #4717

Open
larussverris wants to merge 1 commit into
cloudflare:mainfrom
larussverris:fix/font-module-query-suffixes
Open

larussverris wants to merge 1 commit into
cloudflare:mainfrom
larussverris:fix/font-module-query-suffixes

Conversation

@larussverris

Copy link
Copy Markdown

Font transforms were skipped when Vite added a query or hash suffix to a script module ID, such as layout.tsx?foo. Use a shared module ID regex in both Google and local font filters and guards so these modules receive the existing font processing.

Adds a query-suffix case to the existing tests for each plugin, checking both the hook filter and transform output.

Validation:

  • All 11 font test files pass (243 tests), including build and production tests.
  • Formatting, lint, and type checks pass for all three changed files.

@clanky-the-clanker

Copy link
Copy Markdown

This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting clanky review (or clanker review or @clanky-the-clanker review), optionally followed by instructions (e.g. clanky review focus on the retry logic).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant