Skip to content

fix(metadata): render the remaining Metadata fields Next.js renders - #4754

Closed
ash1day wants to merge 2 commits into
cloudflare:mainfrom
ash1day:fix/metadata-missing-basic-fields
Closed

ash1day wants to merge 2 commits into
cloudflare:mainfrom
ash1day:fix/metadata-missing-basic-fields

Conversation

@ash1day

@ash1day ash1day commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Several Metadata fields that Next.js renders have no output, or a different one:

field Next.js 16.2.6 main f4f6d48
abstract, classification <meta name="abstract">, <meta name="classification"> nothing
archives, assets, bookmarks one <link rel> per value nothing
facebook, pinterest fb:app_id, fb:admins, pinterest-rich-pin nothing
verification.me <meta name="me"> per value nothing
verification.google: ["a", "b"] one tag per value one tag, content="a,b"
formatDetection telephone, date, address, email, url date and url ignored
other: { a: "" } no tag <meta name="a" content="">
appleWebApp.startupImage: ["/a.png"] <link href="/a.png"> <link> without href

This change follows createMetadataElements in packages/next/src/lib/metadata/metadata.tsx. The merge guard for other now accepts the numbers Next.js allows, so a segment with other: { n: 3 } keeps its parent's tags.

Verification

Four pages with these fields: after this change, the tags above equal Next.js 16.2.6 (next start) on vite preview and on workers.dev. Not changed here: Next.js leaves a startup image's URL relative and resolves itunes.appArgument against metadataBase.

Tests

tests/features.test.ts: one case per row, plus merging other values that hold numbers.

abstract, classification, archives, assets, bookmarks, facebook, pinterest
and verification.me had no output. A verification value given as a list
became one comma-joined tag, format-detection ignored date and url, an
empty other value rendered an empty tag, and an Apple startup image given
as a string in a list lost its href.
The merge guard accepted only strings, so a segment whose other held a
number replaced its parent's tags instead of adding to them.
@clanky-the-clanker

Copy link
Copy Markdown

This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting clanky review (or clanker review or @clanky-the-clanker review), optionally followed by instructions (e.g. clanky review focus on the retry logic).

@pkg-pr-new

pkg-pr-new Bot commented Nov 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/@vinext/cloudflare@4754

create-vinext-app

npm i https://pkg.pr.new/create-vinext-app@4754

@vinext/types

npm i https://pkg.pr.new/@vinext/types@4754

vinext

npm i https://pkg.pr.new/vinext@4754

@cloudflare/workers-response-store

npm i https://pkg.pr.new/@cloudflare/workers-response-store@4754

commit: 947187f

@github-actions

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared 947187f against base 7183a4c using alternating same-runner rounds. Next.js was unchanged and skipped.

1 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 152.5 KB 152.5 KB ⚫ 0.0%
Client entry size (gzip) vinext 140.8 KB 140.8 KB ⚫ 0.0%
Dev server cold start vinext 2.23 s 2.20 s ⚫ -1.4%
Dev server cold start (large Pages Router app) vinext 18.19 s 18.28 s ⚫ +0.5%
Production build time vinext 2.72 s 2.67 s 🟢 -2.0%
RSC entry closure size (gzip) vinext 143.0 KB 143.2 KB ⚫ +0.1%
Server bundle size (gzip) vinext 250.9 KB 251.1 KB ⚫ +0.1%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@ash1day
ash1day marked this pull request as draft November 17, 2026 20:56
@ash1day ash1day closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant