Repository navigation
Conversation
abstract, classification, archives, assets, bookmarks, facebook, pinterest and verification.me had no output. A verification value given as a list became one comma-joined tag, format-detection ignored date and url, an empty other value rendered an empty tag, and an Apple startup image given as a string in a list lost its href.
The merge guard accepted only strings, so a segment whose other held a number replaced its parent's tags instead of adding to them.
|
This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting |
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
Performance benchmarksCompared 1 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
ash1day
marked this pull request as draft
November 17, 2026 20:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several
Metadatafields that Next.js renders have no output, or a different one:abstract,classification<meta name="abstract">,<meta name="classification">archives,assets,bookmarks<link rel>per valuefacebook,pinterestfb:app_id,fb:admins,pinterest-rich-pinverification.me<meta name="me">per valueverification.google: ["a", "b"]content="a,b"formatDetectiontelephone,date,address,email,urldateandurlignoredother: { a: "" }<meta name="a" content="">appleWebApp.startupImage: ["/a.png"]<link href="/a.png"><link>withouthrefThis change follows
createMetadataElementsinpackages/next/src/lib/metadata/metadata.tsx. The merge guard forothernow accepts the numbers Next.js allows, so a segment withother: { n: 3 }keeps its parent's tags.Verification
Four pages with these fields: after this change, the tags above equal Next.js 16.2.6 (
next start) onvite previewand on workers.dev. Not changed here: Next.js leaves a startup image's URL relative and resolvesitunes.appArgumentagainstmetadataBase.Tests
tests/features.test.ts: one case per row, plus mergingothervalues that hold numbers.