Repository navigation
Conversation
A directive set to false rendered as an invalid one (nosnippet: false became "nonosnippet"); only index and follow have a no form. Port resolveRobotsValue, which also fixes the directive order.
|
This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting |
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
Performance benchmarksCompared 2 improved · 0 regressed · 5 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A robots directive set to
falserenders as a directive that does not exist:The renderer prefixed
noto everyfalsekey. In Next.js onlyindexandfollowhave anoform; the other directives are left out when false.This change ports
resolveRobotsValue(packages/next/src/lib/metadata/resolvers/resolve-basics.ts). The directives also come out in Next.js's fixed order instead of the object's key order.Verification
Five pages with string, object and
googleBotrobots: therobotsandgooglebottags equal Next.js 16.2.6 (next start) onvite preview(all five) and workers.dev (the two withfalsedirectives).Tests
tests/features.test.ts: directives given out of order withfalsevalues, for both tags.